Create dashboard organization home page #6325
Conversation
acelaya
force-pushed
the
dashboard-org-page
branch
from
a6a05a9 to
3d3cf1b
Compare
| const { organizationPublicId } = useParams<{ | ||
| organizationPublicId: string; | ||
| }>(); |
There was a problem hiding this comment.
useParams() does not return matching params from parent routes when used inside a nested route, so we need to call this here to get the organization ID, and then pass it down as a regular prop to <OrganizationActivity />.
There was a problem hiding this comment.
Maybe the parent route should just be /dashboard, and we should add the /organizations/:organizationPublicId in all routes here, but I think we can delay that decision for now..
acelaya
force-pushed
the
dashboard-org-page
branch
from
3d3cf1b to
92e7a4e
Compare
| @@ -47,11 +52,11 @@ export default function AssignmentActivity() { | |||
| /> | |||
| </div> | |||
| )} | |||
| <h2 data-testid="title" className="text-lg text-brand font-semibold"> | |||
| <CardTitle tagName="h2" data-testid="title"> | |||
There was a problem hiding this comment.
I moved away from CardTitle on a previous PR, but it was actually not needed, so going back to it to have implicit styles.
acelaya
force-pushed
the
dashboard-org-page
branch
2 times, most recently
from
f4b3df5 to
3499120
Compare
| @@ -32,7 +30,7 @@ const descendingOrderColumns: readonly string[] = [ | |||
| * Annotation activity table for dashboard views. Includes built-in support for | |||
| * sorting columns. | |||
| */ | |||
| export default function OrderableActivityTable<T extends BaseDashboardStats>({ | |||
There was a problem hiding this comment.
There was actually no reason for this restriction. Removing it allows for more flexibility when rendering orderable tables.
acelaya
force-pushed
the
dashboard-org-page
branch
from
3499120 to
dd1e748
Compare
acelaya
force-pushed
the
dashboard-org-page
branch
from
dd1e748 to
c6cf4f7
Compare
acelaya
force-pushed
the
dashboard-org-page
branch
from
c6cf4f7 to
62a225e
Compare
There was a problem hiding this comment.
LGTM, with a recommendation regarding table headers. I suspect there will be opportunities to factor out more parts of the different views into shared components, but the best place to draw the line will become clearer when this app is developed a bit further.
| import OrderableActivityTable from './OrderableActivityTable'; | ||
|
|
||
| export type OrganizationActivityProps = { | ||
| organizationPublicId: string; |
There was a problem hiding this comment.
Do we ever receive anything other than the "public" ID for an organization in the frontend? If not, we could use the term organizationId and make it always refer to the "public" ID.
There was a problem hiding this comment.
Yep, I thought about that, but since the terminology is going to change to organization_public_id in the backend to make sure it's not confused with the primary-key id, I thought it would be more clear to use the same terminology in the FE.
I don't have a strong opinion on this though. I think it will be clear enough regardless.
lms/static/scripts/frontend_apps/components/dashboard/OrganizationActivity.tsx
Outdated
Show resolved
Hide resolved
acelaya
force-pushed
the
dashboard-org-page
branch
from
62a225e to
c8a012b
Compare
Add an organization home page where we list the courses that belong to the organization.
Note
The BE does not currently return the amount of assignments per course. We'll add that in a follow-up PR.
Additionally, I took the opportunity to update to the latest frontend-shared patch release, which includes a fix to allow interacting with links inside
DataTables via Enter key.dashboard-home-2024-06-04_10.48.17.mp4
Testing steps