Add granular event hooks (for use in closing Dialogs)
#911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I see the test misses. I'll address shortly. (sorted) |
Codecov Report
@@ Coverage Diff @@
## main #911 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 60 63 +3
Lines 747 790 +43
Branches 271 284 +13
=========================================
+ Hits 747 790 +43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lyzadanger
force-pushed
the
add-event-hooks
branch
from
0f0cb1e to
f32f16b
Compare
|
I thought test coverage was happy but now it's not again. I'll deal with it later; it's trivial. |
lyzadanger
force-pushed
the
add-event-hooks
branch
from
b27559b to
d825f62
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #910
Fixes #900
Part of #77
This PR decomposes the functionality of
useElementShouldCloseinto three separate, more-generic hooks, and aligns withuseArrowKeyNavigationin the use ofListenerCollectionfor managing event listeners. This will allow more nuanced control forDialogs.There's some opportunity to DRY this out some in the future (especially in tests), but I started with the simplest approach possible here.
Just like with
Dialog, I imagine we might make these hooks part of the package's public API (and deprecateuseElementShouldClose). But let's do that later and separately.