Make close behavior for Dialogs more granular, configurable #912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelaya
approved these changes
Mar 10, 2023
lyzadanger
force-pushed
the
add-event-hooks
branch
from
b27559b to
d825f62
Compare
Also: change default such that `closeOnClickAway` is not enabled for modal dialogs.
lyzadanger
force-pushed
the
update-close-behavior
branch
from
6e81b67 to
45f6026
Compare
Codecov Report
@@ Coverage Diff @@
## main #912 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 790 795 +5
Branches 284 287 +3
=========================================
+ Hits 790 795 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the use of
useElementShouldClosewith newly-added, more granular hooks. Modal Dialogs still default to close on ESC, but no longer default to close on click-away or focus-away (this more closely echoes the nativedialogelement behavior). But all three behaviors can be controlled via props.This is documented on the
Dialogpattern-library page, so I'll leave it to the reviewer to determine whether the documentation is clear enough!Part of #77
Depends on #911