Unify member variable naming

[vaxerski]

Description

If someone is bored, can you unify member variable naming? I've initially used hungarian + m, m_bBooleanValue but then I stopped, if someone can just move it to camel + m_ for members it would be nice. (m_value, m_speed, m_amogus)

obviously m_ for members of classes / structs

[ninetailedtori]

I could for sure :)
Lemme go through it all with a linter or smth, I'll write up a linter format for hypr :)

[vaxerski]

we have clang-tidy, if you know how to write a lint rule for that and auto apply it, would be appreciated

[ninetailedtori]

Ah, yea I can do that :)

[vaxerski]

@ninetailedtori any progress on that?

[ninetailedtori]

Yep, it's nearly done. Lemme commit it to my fork in a bit :)

[vaxerski]

thanks! no hurries, just wanted to check in

[ninetailedtori]

Yep, after my clang-tidy and redo of several grammatical fixes...there's about 850 renames I'm about to push to my fork...heheh. Do you want ALL global pointers to have g_, or only the singleton pointers? If all, I can more easily do the formatting, but if not, then I'll need to be a little more careful.

[vaxerski]

are there any other global pointers? all is fine.

[ninetailedtori]

misc-use-internal-linkage wants us to move a bunch of functions into a single file, but the intent is to forward-declare, yes? So it might be worth modifying clang-tidy again. I'll fix the config. Unless you'd like me to move everything into an anonymous namespace for each file, and fix the includes? It will break a lot of shit though, as I can't forward declare it. It will have to move to just cpp source files and inline exports.

[ninetailedtori]

To be honest, hyprctl is already in a single file, and can be statically linked, or anonymous namespaced with ease. It might be worth moving some of the others over too, but it depends on compile time. It's a lot faster at runtime to use anonymous, but to forward-declare is faster compile.

[vaxerski]

ignore clang-tidy for now, just change the variable naming. Other clang-tidy stuff can be dealt with later.

[ninetailedtori]

Yep it's bed time, I'm gonna sort the rest out tmr and hopefully can get the whole repo sorted within a few days. We'll have to do the others as well though...aquamarine especially.

[vaxerski]

no, just Hyprland. Libraries can't be changed due to API breaks. We'll have to live with that.

[ninetailedtori]

That's fair. I've had a blood test today so I'll be out of it for a bit, but I'll get back to it when I can, and update this thread.