Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unify all Hyprland code w.r.t. code styling guidelines (c.f. #9522) #9543

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from

Conversation

ninetailedtori
Copy link
Contributor

Describe your PR, what does it fix/add?

#9061 - Unification of code styling guidelines w.r.t. our contribution rulesets. This is a major refactoring change, and as such will likely be quite broken until everything is fixed. There were also a ton of typos and grammatical fixes I included.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

  • There are a LOT of variable name changes, which are still happening in this PR. There WILL be breakages.
  • clang-format and clang-tidy, I'd like to update them to a newer version in our GH workflows as well, but don't know too much about it. I threw a few errors with formatting on my own fork, regarding things like ReflowComments: 'Indent' etc.
  • There are some additions of files. These are just forward declarations in header and creation of source files. This is to reduce compile times and stay consistent with style guidelines.

Is it ready for merging, or does it need work?

  • Complete?
  • Tested?
  • Supported testing from others?
  • Patches required?
  • Patches done?
  • Merged?

ninetailedtori and others added 23 commits March 2, 2025 16:58
…ured older right now. TODO: add specific jobs for separate clang-format versions.
… made in mass to classes. Then need to deal with the remaining member variables that I haven't refactored as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant