Unify member variable naming

[ninetailedtori]

Describe your PR, what does it fix/add?

#9061 - Unification of code styling guidelines w.r.t. our contribution rulesets. This is a major refactoring change, and as such will likely be quite broken until everything is fixed. There were also a ton of typos and grammatical fixes I included.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

• There are a LOT of variable name changes, which are still happening in this PR. There WILL be breakages.
• clang-format and clang-tidy, I'd like to update them to a newer version in our GH workflows as well, but don't know too much about it. I threw a few errors with formatting on my own fork, regarding things like ReflowComments: 'Indent' etc.
• There are some additions of files. These are just forward declarations in header and creation of source files. This is to reduce compile times and stay consistent with style guidelines.

Is it ready for merging, or does it need work?

• Complete?
• Tested?
• Supported testing from others?
• Patches required?
• Patches done?
• Merged?

[vaxerski]

can you remove all changes that are not in .hpp or .cpp files? (well or .clang-tidy)

[ninetailedtori]

can you remove all changes that are not in .hpp or .cpp files? (well or .clang-tidy)

Ok, this problem will be dealt with at a later stage. Unable to shift them to a new branch right now. I'm busy going through all my changes and typo-proofing them, as the editor was a bit wacky to what I wanted. I could also just...branch this entire changes off, and then reset this PR to upstream head, then redo the changes again if you want?

[vaxerski]

up to you

[C0Florent]

Why would you remove the newline at the end of file?

[ninetailedtori]

Thank you for letting me know. I'll handle it in a bit. Or you can if you like help and PR a bunch of checks to my fork, but I'd rather handle it in batch.

[C0Florent]

Thanks for answering respectfully, I didn't realise this was still heavily a work-in-progress, that's my bad.

Good luck making your changes

[ninetailedtori]

Thank you for the well wishes and understanding. 😄

[ninetailedtori]

Chat... this literally says it's nowhere near complete. Please stop commenting on typos and weird newline changes. I didn't do them all, many were caused by vsc and clang-tidy, and I'm going through them manually, as I have been. Please leave this thread alone until I send a comment here stating it's ready for checking. Thank you for your understanding! 🙂

[vaxerski]

maybe mark as draft then?

[ninetailedtori]

maybe mark as draft then?

Err I actually don't know how to do that...should I just delete the PR and redo it as a draft?

[ninetailedtori]

Redoing this one as a draft, moving thread.