-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Emitter.emit calls #362
Comments
This was partially addressed in #360 to unblock the hackathon release, but I more detailed pass is still required. I plan to take some time away from examples tomorrow to work on this |
Current Status:
@Tomas2D are the tools and workflow implementations temporary or intentional? Depending on your answer this can close once #363 and #383 are merged |
Unblocks #391 |
@grahamwhiteuk i have unchecked tool base, workflow. from my understanding these do not yet have emitter i noticed you checked all of them. is there something i missed? thx |
@vabarbosa that's my mistake, I hadn't read Alex's comment thoroughly enough when I was checking through this morning. |
@ajbozarth i think we should now be able to close this or are there any other work this needed? |
Though we managed to add the emitter and include the emit calls in the agent and run context, we did not add them anywhere else. We should go through and reach parity with TS on emitter calls in locations that we already have implemented. On an initial pass that would include:
The text was updated successfully, but these errors were encountered: