Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Emitter.emit calls #362

Closed
6 tasks done
ajbozarth opened this issue Feb 21, 2025 · 7 comments
Closed
6 tasks done

Add Emitter.emit calls #362

ajbozarth opened this issue Feb 21, 2025 · 7 comments
Assignees
Labels
python Python related functionality

Comments

@ajbozarth
Copy link
Member

ajbozarth commented Feb 21, 2025

Though we managed to add the emitter and include the emit calls in the agent and run context, we did not add them anywhere else. We should go through and reach parity with TS on emitter calls in locations that we already have implemented. On an initial pass that would include:

  • context
  • bee agent
  • default runner
  • backend chat
  • tools base
  • workflow
@ajbozarth ajbozarth added the python Python related functionality label Feb 21, 2025
@ajbozarth ajbozarth self-assigned this Feb 21, 2025
@ajbozarth
Copy link
Member Author

This was partially addressed in #360 to unblock the hackathon release, but I more detailed pass is still required. I plan to take some time away from examples tomorrow to work on this

@ajbozarth
Copy link
Member Author

Current Status:

@Tomas2D are the tools and workflow implementations temporary or intentional? Depending on your answer this can close once #363 and #383 are merged

@mmurad2
Copy link
Contributor

mmurad2 commented Feb 25, 2025

Unblocks #391

@mmurad2 mmurad2 assigned vabarbosa and grahamwhiteuk and unassigned ajbozarth Feb 25, 2025
@vabarbosa
Copy link
Contributor

vabarbosa commented Feb 26, 2025

@grahamwhiteuk i have unchecked tool base, workflow. from my understanding these do not yet have emitter

i noticed you checked all of them. is there something i missed? thx

@grahamwhiteuk
Copy link
Contributor

@vabarbosa that's my mistake, I hadn't read Alex's comment thoroughly enough when I was checking through this morning.

@vabarbosa
Copy link
Contributor

@ajbozarth i think we should now be able to close this or are there any other work this needed?

@ajbozarth
Copy link
Member Author

Closing this as #416 and #429 have closed out the remaining work. Emitters should be added alongside the features that use them from now on. Additionally I updated #431 to reflect the newly added events

@ajbozarth ajbozarth self-assigned this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python related functionality
Projects
None yet
Development

No branches or pull requests

4 participants