feat: add runcontext + retryable + emitter to tool #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: va <va@us.ibm.com>
Tomas2D
requested changes
Feb 28, 2025
python/beeai_framework/tools/tool.py
Outdated
| def __init__(self, options: dict[str, Any] | None = None) -> None: | ||
| super().__init__(options) | ||
| # replace any non-alphanumeric char with _ | ||
| formatted_name = re.sub(r"\W+", "_", self.name).lower() |
There was a problem hiding this comment.
I noticed that you were already using this helper somewhere, please create a utility function in utils/strings.py
Signed-off-by: va <va@us.ibm.com>
Signed-off-by: va <va@us.ibm.com>
Signed-off-by: va <va@us.ibm.com>
Tomas2D
previously approved these changes
Feb 28, 2025
Signed-off-by: va <va@us.ibm.com>
ajbozarth
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this pull-request address?
Contributes-to: #362
Description
this PR adds the
RunContext,RetryableandEmittercalls to Tool. Tool related examples were updated accordinglyChecklist
poe lintpoe formatpoe test --type unitpoe test --type e2e