Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add runcontext and emitter to workflow #416

Merged
merged 15 commits into from
Feb 28, 2025
Merged

feat: add runcontext and emitter to workflow #416

merged 15 commits into from
Feb 28, 2025

Conversation

vabarbosa
Copy link
Contributor

@vabarbosa vabarbosa commented Feb 26, 2025 •
edited
Loading

Which issue(s) does this pull-request address?

Contributes-to: #362

Description

this PR adds the RunContext and Emitter calls to Workflow. a workflow emitter example was also added examples/workflows/emitter.py

Checklist

  • I have read the contributor guide
  • I have signed off on my commit
  • Linting passes: poe lint
  • Formatting is applied: poe format
  • Unit tests pass: poe test --type unit
  • E2E tests pass: poe test --type e2e
  • Tests are included
  • Documentation is changed or added
  • Commit messages and PR title follow conventional commits

@vabarbosa
feat: add runcontext and emitter to workflow
58f5868 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa vabarbosa added the python Python related functionality label Feb 26, 2025
@vabarbosa vabarbosa self-assigned this Feb 26, 2025
@vabarbosa vabarbosa requested a review from a team as a code owner February 26, 2025 21:10
@vabarbosa
chore: update print
a348e44 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa
chore: update example
9383fd9 
Signed-off-by: va <va@us.ibm.com>
ajbozarth
ajbozarth reviewed Feb 26, 2025
View reviewed changes
Copy link
Member

@ajbozarth ajbozarth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI this properly addresses #362 for workflows

@vabarbosa
fix: update agentworkflow
608741a 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa
fix: update example
4bd6db9 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa
fix: feedback review
6555bd7 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa vabarbosa requested a review from Tomas2D February 27, 2025 06:15
@vabarbosa
Merge branch 'main' into feat/workflow-emitter
7eaa57f
@vabarbosa
fix: update examples
a362003 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa
docs: build
9004eb4 
Signed-off-by: va <va@us.ibm.com>
Tomas2D
Tomas2D requested changes Feb 27, 2025
View reviewed changes
@ajbozarth ajbozarth mentioned this pull request Feb 28, 2025
Open
Tomas2D
Tomas2D previously approved these changes Feb 28, 2025
View reviewed changes
@ajbozarth ajbozarth mentioned this pull request Feb 28, 2025
Merged
11 tasks
@vabarbosa
fix: review feedback
f8b1d1a 
Signed-off-by: va <va@us.ibm.com>
@vabarbosa vabarbosa merged commit 4894b81 into main Feb 28, 2025
5 checks passed
@vabarbosa vabarbosa deleted the feat/workflow-emitter branch February 28, 2025 17:18
@ajbozarth ajbozarth mentioned this pull request Feb 28, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajbozarth ajbozarth ajbozarth left review comments

@Tomas2D Tomas2D Tomas2D approved these changes

@grahamwhiteuk grahamwhiteuk Awaiting requested review from grahamwhiteuk

@michael-desmond michael-desmond Awaiting requested review from michael-desmond

Assignees

@vabarbosa vabarbosa

Labels
python Python related functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vabarbosa @ajbozarth @Tomas2D