Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the types and use exposed types from i18next #319

Merged
merged 6 commits into from
Aug 3, 2019

Conversation

rosskevin
Copy link
Collaborator

@rosskevin rosskevin commented Aug 1, 2019

@rosskevin
Copy link
Collaborator Author

I've got local changes ready to go, waiting on the upstream PR to be merged so we can get a green build again.

@rosskevin rosskevin closed this Aug 2, 2019
@rosskevin rosskevin reopened this Aug 2, 2019
@rosskevin
Copy link
Collaborator Author

Still needs some updates to usage of internal services. i18next/i18next#1297 (comment)

I have pushed all my local changes.

@rosskevin rosskevin assigned jamuhl and unassigned rosskevin Aug 2, 2019
@jamuhl jamuhl merged commit f2d53da into i18next:master Aug 3, 2019
@jamuhl
Copy link
Member

jamuhl commented Aug 3, 2019

published in i18next-xhr-backend@3.0.1

@Kamahl19
Copy link

Kamahl19 commented Aug 3, 2019

I have updated to i18next 17.0.8 & i18next-xhr-backend 3.0.1 but I am still getting an error

Argument of type 'typeof I18NextXhrBackend' is not assignable to parameter of type 'Module | ThirdPartyModule[]'.
  Type 'typeof I18NextXhrBackend' is missing the following properties from type 'ThirdPartyModule[]': pop, push, concat, join, and 27 more.  TS2345

@caroe233
Copy link

caroe233 commented Aug 5, 2019

I have updated to i18next 17.0.8 & i18next-xhr-backend 3.0.1 but I am still getting an error

Argument of type 'typeof I18NextXhrBackend' is not assignable to parameter of type 'Module | ThirdPartyModule[]'.
  Type 'typeof I18NextXhrBackend' is missing the following properties from type 'ThirdPartyModule[]': pop, push, concat, join, and 27 more.  TS2345

Me too :(

It seems in the change the XHR Backend is typed as BackendModule but the i18next change expects a Module ... ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants