Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct use(module) types #1296

Merged
merged 5 commits into from
Aug 1, 2019
Merged

Correct use(module) types #1296

merged 5 commits into from
Aug 1, 2019

Conversation

rosskevin
Copy link
Collaborator

@rosskevin rosskevin commented Aug 1, 2019

This is going to be a cascading set of changes across projects. Tightening the use() method args in #1291 exposed that the downstream types were incorrect, and the types here were not flexible enough to accomodate.

Closes #1294 (along with related PRs in other repos)

Rebuild and merge after this release:

rosskevin added a commit to rosskevin/i18next-xhr-backend that referenced this pull request Aug 1, 2019
rosskevin added a commit to rosskevin/i18next-browser-languageDetector that referenced this pull request Aug 1, 2019
rosskevin added a commit to rosskevin/react-i18next that referenced this pull request Aug 1, 2019
@rosskevin rosskevin removed the pr hold label Aug 1, 2019
@rosskevin rosskevin merged commit 88b04cc into i18next:master Aug 1, 2019
@rosskevin rosskevin deleted the ts-use branch August 1, 2019 17:10
@rosskevin
Copy link
Collaborator Author

@jamuhl this is ready to release as a patch. Once released, the PRs linked in the description need to be triggered (they are setup to pull the next patch) to be released as related fixed to fully solve #1294

@jamuhl
Copy link
Member

jamuhl commented Aug 1, 2019

published in i18next@17.0.8

@rosskevin
Copy link
Collaborator Author

rosskevin added a commit to i18next/react-i18next that referenced this pull request Aug 1, 2019
@mgroenhoff
Copy link
Contributor

If you have the time can you please also update the typings at DT for i18next-node-fs-backend?

@jamuhl
Copy link
Member

jamuhl commented Aug 6, 2019

@mgroenhoff This is open source - I highly appreciate the work @rosskevin provides in adding types to i18next - still my personal opinion is - if people use those modules and need typings for them it's not asked too much to create a PR there (this is not paid software)?

Honestly, I was negatively surprised how many typescript users love to contribute to creating issues and giving thumbs up on them - but none of them volunteer and provide a PR.

@mgroenhoff
Copy link
Contributor

@jamuhl Ofcourse am I ware that it is open-source and I highly appreciate what everyone is doing for the TypeScript (heck all of open-source) community. I kindly asked if he had the time. If not I can do it myself but since @rosskevin is the author of these changes I thought it might not be too much trouble for him as he exactly knows that has changed and why. I do not, so I have to spend time figuring out what changes were made and fix our build because breaking changes in typings keep occurring in non-breaking change semver updates.

@jamuhl I don't know why my question made u answer in such a way but I was just trying to be polite and not trying to offend anyone. He is perfectly capable and in his right to answer with no.

@jamuhl
Copy link
Member

jamuhl commented Aug 6, 2019

@mgroenhoff look I didn't want to sound rude - even less against you personally - this is just my general observation from the last days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeScript use plugin issue
3 participants