Refactor <ColumnView> and <Modal> #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhusee2
force-pushed
the
feature/refactor_modal
branch
from
f46619d to
0093dcc
Compare
tz5514
reviewed
Sep 2, 2019
| }; | ||
|
|
||
| ColumnView.defaultProps = { | ||
| header: undefined, | ||
| footer: undefined, | ||
| bottomPadding: undefined, | ||
| flexBody: false, | ||
| bodyPadding: { bottom: 24 }, |
There was a problem hiding this comment.
Other padding should has default value 0?
There was a problem hiding this comment.
If you don't provide it, it should be undefined and thus it will not be written to CSS.
And thus it would be initial, which happens to equal 0 here.
I think it's fine though.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The primary goal is to replace the inner layout of
<Modal>with<ColumnView>.It should turn on momentum scrolling on iPads, as well as a default bottom padding.
Changes
Breaking
bottomPaddingprop is removed. Please usebodyPaddingprop and pass an object instead.<Modal>is refactored to render a<ColumnView>as its inner layout.<Modal>no longer takessizeandbodyClassNameprops.<Modal bodyPadding>prop now takes the same object and is passed to<ColumnView>.Other changes
<SplitView>is refactored so they can be reused.