Code

Refactor <ColumnView> and <Modal>#224

Code

Merged

zhusee2 merged 14 commits intodevelopiCHEF/gypcrete:developfrom feature/refactor_modaliCHEF/gypcrete:feature/refactor_modalCopy head branch name to clipboardSep 2, 2019

+373-495

Commits

Commits on Aug 26, 2019

• Refactor <ColumnView> to take a 'bodyPadding' object as prop

  zhusee2

  committed
  3392819

  Copy full SHA for 3392819

Commits on Aug 30, 2019

• Add 'flexBody' prop for <ColumnView> to make its body a Flexbox

  zhusee2

  committed
  63ac884

  Copy full SHA for 63ac884

• Simplify <ColumnView> for optional parts

  zhusee2

  committed
  01c42ea

  Copy full SHA for 01c42ea

• Fix <ColumnView> header should be above its body

  zhusee2

  committed
  f026194

  Copy full SHA for f026194

• Fix tests for <ColumnView>

  zhusee2

  committed
  3405cff

  Copy full SHA for 3405cff

Commits on Sep 2, 2019

• Refactor <Modal> to use <ColumnView> as its scrollable layout

  zhusee2

  committed
  8b035dd

  Copy full SHA for 8b035dd

• Remove incorrect type annotation of 'wrapIfNotElement()'

  zhusee2

  committed
  7192fc4

  Copy full SHA for 7192fc4

• Refactor <Modal> to a function component

  zhusee2

  committed
  defd6d2

  Copy full SHA for defd6d2

• Update tests for <Modal>

  zhusee2

  committed
  d5d1ebd

  Copy full SHA for d5d1ebd

• Fix demo for <SplitView> to match prop changes of <ColumnView>

  zhusee2

  committed
  8a78637

  Copy full SHA for 8a78637

• Refactor examples for <SplitView> so they can be reused

  zhusee2

  committed
  1ede319

  Copy full SHA for 1ede319

• Fix props table in <SplitView> example wrapped by unwanted decorators

  zhusee2

  committed
  8e852d8

  Copy full SHA for 8e852d8

• Update examples for <Modal>

  zhusee2

  committed
  37f08c3

  Copy full SHA for 37f08c3

• Update CHANGELOG about <ColumnView> and <Modal> refactors

  zhusee2

  committed
  0093dcc

  Copy full SHA for 0093dcc