[Feature] Allow passing remaining props to wrapper element to add attribute (e.g. test id) #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhusee2
reviewed
May 13, 2020
|
或者如果只有單個地方要埋就給單個 |
benny0642
approved these changes
May 13, 2020
|
覺得可以整理一下可能的情境，我們 Tech meeting 一起討論一下 |
chenesan
force-pushed
the
feature/add-test-id-pt1
branch
from
98a71ed to
e4ace99
Compare
chenesan
changed the title
kyoyadmoon
reviewed
May 15, 2020
| @@ -100,10 +100,11 @@ class StatusIcon extends PureComponent { | |||
| } | |||
|
|
|||
| render() { | |||
| const rootClassName = ROOT_BEM.modifier(this.props.position); | |||
| const { status, position, ...wrapperProps } = this.props; | |||
kyoyadmoon
reviewed
May 15, 2020
packages/core/src/StatusIcon.js
Outdated
| @@ -119,7 +120,7 @@ class StatusIcon extends PureComponent { | |||
| break; | |||
| } | |||
|
|
|||
| return (icon && <span className={rootClassName}>{icon}</span>); | |||
| return (icon && <span className={rootClassName} {...wrapperProps}>{icon}</span>); | |||
There was a problem hiding this comment.
Suggested change
| return (icon && <span className={rootClassName} {...wrapperProps}>{icon}</span>); | |
| return (icon && ( | |
| <span className={rootClassName} {...wrapperProps}> | |
| {icon} | |
| </span> | |
| )); |
benny0642
approved these changes
May 18, 2020
chenesan
force-pushed
the
feature/add-test-id-pt1
branch
from
6cc9d31 to
a2daa7f
Compare
2 tasks
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
修改了下列的 component，讓所有的 gypcrete component 都可以帶 props 到最外層的元素上，用於加 test id。例如
<List data-test-id="menu-item-list" />。<Modal><Section><SearchInput><StatusIcon><Tag><Text><TextEllipsis><SelectList>Changes
Review Tips
有一些已經把 remaining props 放在內層元素上，所以沒有修改：
<TextInput>props 會傳到裡面的
<input><SelectOption>props 會傳到裡面的
<Checkbox>，外層的<ListRow>吃不到。<ImageEditor>props 會傳到
react-avatar-editor上面一些 component 裡面的元素也許想要加 props 進去：
<Section>(即<List>)裡面有 title 和 desc
<SearchInput>裡面有 search button 和 input
<StatusIcon>裡面有
<Icon><Switch>裡面有 checkbox input
<Text>裡面有 basic 和 aside
<SelectList>全選的 option 沒辦法傳 props 進去
<SelectRow>裡面的
<Text>和<Popover>沒辦法傳 props 進去，<ListRow>和<SelectList>已經有了<SwitchRow>裡面的
<TextLabel>沒辦法傳 props 進去<ImageEditor>裡面的 control 沒辦法傳 props 進去。
想問問大家要不要再加；或是就先做到這邊，等和 QE 協作再看有沒有需求。個人覺得可以先額外開洞允許傳 props 到 button/input 上。
TODOs