[Bugfix] Fix passing invalid props to dom element #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
benny0642,
kyoyadmoon,
tz5514 and
zhusee2
zhusee2
reviewed
Jun 4, 2020
| @@ -0,0 +1,5 @@ | |||
| import omit from 'lodash.omit'; | |||
|
|
|||
| export default function getRemainingProps(props, Component) { | |||
There was a problem hiding this comment.
覺得這邊可以直接傳 propTypes 進去就好
Suggested change
| export default function getRemainingProps(props, Component) { | |
| export default function getRemainingProps(props, componentPropTypes) { |
| const { innerValue } = this.state; | ||
|
|
||
| const inputValue = this.isControlled() ? value : innerValue; | ||
| const isLoading = this.context.status === STATUS_CODE.LOADING; | ||
| const rootClassName = classNames(className, `${BEM.root}`); | ||
|
|
||
| const wrapperProps = getRemainingProps(this.props, SearchInput.propTypes); |
tz5514
approved these changes
Jun 5, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
lodash.omit的 dependency。抽出了getRemainingProps的 utility。<Text>story 中噴出來的 error message，起因於錯誤的 import<StatusIcon>Changes
Risk
Usually none, if you have any please write it here.
TODOs