Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temperature sensors support #670

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Conversation

shellixyz
Copy link
Collaborator

@shellixyz shellixyz commented Feb 2, 2019

Configurator support for iNavFlight/inav#4282

  • Add temperatures to sensor tab
  • Add OSD elements

@shellixyz shellixyz merged commit 0a720f4 into iNavFlight:master Feb 8, 2019
@ghost
Copy link

ghost commented Feb 17, 2019

Can I make a suggestion. After viewing the labels beside their temperature readouts.
As can be seen from the picture. There is a rather large gap between the label and the actual temperature value. Almost enough for the glyph's above it to fall through ;-)

I do understand that this gives a space between the Label and the temp readout value. Although, it ends up being a gap of, up to 5 spaces. If only a one character label is used.

Would it be possible to make the labels, first character positioning, with one space between it and the temperature value. And every other character(up to 4) would appear to the left of that first character? So that there is only ever a one character spacing between the label and temp value.

Don't take this as criticism...I do understand your dilemma; in keeping all the characters lined up on both the label and the °C or °F end.
I just thought it might be more viewable with them closer together. Especially if just one temp value is located in the midst of other characters on a cluttered OSD page.

capture

@shellixyz
Copy link
Collaborator Author

Indeed there can be a lot of space between the label and temperature if the label is short. I thought keeping the label alignment was the best thing to do. We can maybe add an alignment setting to chose between left or right alignment for the label but I think this issue will be solved when the possibility to use a symbol instead of the label will be added, so that less space is used. What do you think ?

@ghost
Copy link

ghost commented Feb 20, 2019

Did you give it anymore thought. With respect to an alignment setting or changing to the symbols?
I'm happy with either.
But after using it in its present form. The gap between the label and temp value is very excessive.

@shellixyz
Copy link
Collaborator Author

I haven't had time to take care of it. I had some more important things to do for the release (bugfix and other stuff) and the final release was planned for today so I thought it wouldn't be merged anyway. I'll take a look tomorrow if I have time, maybe it can be merged its not critical stuff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant