Temp sensors improvements #4282

shellixyz · 2019-01-28T10:06:56Z

Add 1-Wire support through the DS2482 IF chip (new driver)
Add driver for the DS18B20 1-Wire temperature sensor
Support for multiple LM75 sensors
Support for the DS18B20 sensors
Add CLI command temp_sensor to configure sensors
Logging of all temperature sensor values
Display of all temperature sensor values on the OSD with support for alarms
New MSP messages to query and set sensor configuration and read temperatures
Enable 1-Wire and DS18B20 temp sensors on all F4 and F7 targets
Up to 8 temperature sensors supported

Syntax of the temp_sensor command:

temp_sensor reset to reset the temperature sensor configuration
temp_sensor index type address alarm_min alarm_max label. Max label length 4 chars. Type: 0=NONE, 1=LM75, 2=DS18B20

Configurator part: iNavFlight/inav-configurator#670

ghost · 2019-01-28T13:14:42Z

Your a work horse shelli. ; )

These are some idea's to define the External temperature sensor from the Internal barometer temperature reading.
The EXT or Thermometer is the most probable. The others are just descriptive of the things that it will be used for. Likely a waste of 7456 memory, adding them all.

Temp sensor devices.zip

wx4cb · 2019-01-28T13:34:27Z

How about just a "TMP" one? Unless these already exist in the font then i would say ext

…

On Mon, Jan 28, 2019, 08:14 kardon18 ***@***.*** wrote: Your a work horse shelli. ; ) These are some idea's to define the External temperature sensor from the Internal barometer temperature reading. The EXT is the most probable. The others are just descriptive of the things that it will be used for. Likely a waste of 7456 memory, adding them all. [image: external temp sensor] <https://user-images.githubusercontent.com/43928973/51838162-a3e0f000-2359-11e9-94f7-edb6153d6cee.PNG> [image: motor] <https://user-images.githubusercontent.com/43928973/51838163-a4798680-2359-11e9-9f1c-d2bf1f38d74f.PNG> [image: vtx] <https://user-images.githubusercontent.com/43928973/51838165-a4798680-2359-11e9-9e98-7f7619d82d5d.PNG> [image: battery] <https://user-images.githubusercontent.com/43928973/51838166-a5121d00-2359-11e9-9231-811eb47bf81e.PNG> [image: esc] <https://user-images.githubusercontent.com/43928973/51838169-a5aab380-2359-11e9-85d6-be32a2932bb5.PNG> Temp sensor devices.zip <https://github.com/iNavFlight/inav/files/2803054/Temp.sensor.devices.zip> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#4282 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbRAUCGpgfuYuYnIAQDbY5KXkvVO6pTks5vHvfDgaJpZM4aVksu> .

shellixyz · 2019-01-28T22:28:03Z

@kardon18 Good idea it will help save space on the screen by replacing labels. Could you make one for MPU and baro temperature ?

ghost · 2019-01-29T00:45:05Z

@shellixyz Good idea it will help save space on the screen by replacing labels. Could you make one for MPU and baro temperature ?

I was hoping to have a descriptive icon for the temperature of the device we are measuring. That way we can look at a glance.
I'm glad you included an ALARM for over temperature in the code 👍

When you stated MPU. I assume you were refering to the Accelerometer/Gyro. Not "Micro Processor Unit". Being that both can use internal components to read temperature.
That being said. I wrote MPU as IMU. Because its impossible to fit "MPU" across 12 pixels. Due to the width of the 'M". But with 'I" it will fit.

Hope that's okay. If not, let me know.

Internal temp sensor.zip

wx4cb · 2019-01-29T00:47:54Z

if its going to be the processor temp, then why MPU not CPU ?

…

On Mon, 28 Jan 2019 at 19:45, kardon18 ***@***.***> wrote: @shellixyz <https://github.com/shellixyz> Good idea it will help save space on the screen by replacing labels. Could you make one for MPU and baro temperature ? I was hoping to have a descriptive icon for the temperature of the device we are measuring. That way we can look at a glance. I'm glad you included an ALARM for over temperature in the code 👍 When you stated MPU. I assume you were refering to the Accelerometer/Gyro. Not "Micro Processor Unit". Being that both can use internal components to read temperature. That being said. I wrote MPU and IMU. Because its impossible to fit "MPU" across 12 pixels. Due to the width of the 'M". But with 'I" it will fit. Hope that's okay. If not, let me know. [image: barometer temperature] <https://user-images.githubusercontent.com/43928973/51875739-416c0c00-23ba-11e9-922d-43d2c3cd8ad1.PNG> [image: imu temp] <https://user-images.githubusercontent.com/43928973/51875757-49c44700-23ba-11e9-97ff-29158aceb188.PNG> Internal temp sensor.zip <https://github.com/iNavFlight/inav/files/2805518/Internal.temp.sensor.zip> — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#4282 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbRAVLOssdJUTpKbG6O4dUh_B9ZjxEKks5vH5mSgaJpZM4aVksu> .

shellixyz · 2019-01-29T02:21:06Z

@kardon18 MPU is for Motion Processing Unit (gyro + accelerometer). IMU is good 👍. Thank you the new symbols will fit the purpose.

@wx4cb On top of the possibility to connect dedicated temperature sensor we are reading the gyro/acc chip and baro temperature. We are not reading MCU temp. Maybe it is possible, I don't know.

fiam · 2019-01-29T23:30:40Z

We could have a generic temperature character on page 1 and specific ones on page 2.

ghost · 2019-01-30T14:19:43Z

We could have a generic temperature character on page 1 and specific ones on page 2.

I suppose that it depends on how many sensors the model will have on it.
e.g. One user may want to read the temperature of 4 motors or ESC's. While another may what to read the temperature of 1 ESC or a VTX.

What do you guys have in mind for the selection ability?
CLI command? Or drop down box's in the configurator?

The user would need the ability to select -

How many sensors they are using.
Then define a label for each.
Set an alarm preset for each corresponding sensors label.

shellixyz · 2019-01-30T15:57:04Z

I was just going to add an option to the temp_sensor command to chose between a char to display and the label. Take a look at the description I added the current syntax for the command.

ghost · 2019-01-30T22:27:53Z

I was just going to add an option to the temp_sensor command to chose between a char to display and the label. Take a look at the description I added the current syntax for the command.

I think that's perfectly fine. 👍
In reality, most users will be more than happy to have one external temp sensor. With the ability to choose a sensor label, and give it an icon for recognition.

As you spoke of earlier. To add more sensors, it would require the use of a DS2482-100, I2C interface chip. So most users wouldn't go to that much effort. Although. I do remember reading on the RCG ET Vector forum. Many people requested the desire of an expansion of its temperature sensor ability, out to 4 or 6. So the motor temperatures on their multirotors could be measured.

But there is away the possibility for expansion in future releases.

shellixyz · 2019-01-30T22:40:57Z

To be honest adding a DS2482 is really simple with the help of a SO8 breakout and cheap. You can get 10 of them for $5 on AliExpress

wx4cb · 2019-01-30T23:31:56Z

If you are wishing to monitor motors, personally i would suggest blheli32 and wait for the telemetry to get done.

…

On Wed, Jan 30, 2019, 17:27 kardon18 ***@***.*** wrote: I was just going to add an option to the temp_sensor command to chose between a char to display and the label. Take a look at the description I added the current syntax for the command. I think that's perfectly fine. 👍 In reality, most users will be more than happy to have one external temp sensor. With the ability choose sensor label, and give it a icon for recognition. As you spoke of earlier. To add more sensors, it would require the use of a DS2482-100, I2C interface chip. So most users wouldn't go to that much effort. Although. I do remember reading on the RCG ET Vector forum. Many people requested the desire of an expansion of its temperature sensor ability, out to 4 or 6. So the motor temperatures on their multirotors could be measured. But there is away the possibility for expansion in future releases. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4282 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbRASBLmqszRdil-4ro1N4j2_0qKEnHks5vIhxqgaJpZM4aVksu> .

shellixyz · 2019-01-30T23:53:30Z

BLHeli32 does not monitor motors temperature. The temperature of the ESC itself yes, the motor no.

wx4cb · 2019-01-31T00:25:28Z

BLHeli32 does not monitor motors temperature. The temperature of the ESC itself yes, the motor no.

I realise that, that's what I meant, but i have no clue how you would measure the actual "motor" temp as it's kinda... spinning really fast lol :D

shellixyz · 2019-01-31T00:46:50Z

What gets hot is the base not the bell. You can put a sensor in contact with the motor base.

hali9 · 2019-02-01T19:44:55Z

src/main/telemetry/ibus_shared.c

@@ -141,8 +141,12 @@ static uint8_t dispatchMeasurementRequest(ibusAddress_t address) {
    }
 #endif
    if (SENSOR_ADDRESS_TYPE_LOOKUP[address].value == IBUS_MEAS_VALUE_TEMPERATURE) { //BARO_TEMP\GYRO_TEMP
-        if (sensors(SENSOR_BARO)) return sendIbusMeasurement2(address, (uint16_t) ((DEGREES_TO_CENTIDEGREES(getCurrentTemperature()) + 50) / 10  + IBUS_TEMPERATURE_OFFSET)); //int32_t
-        else {
+        /*if (sensors(SENSOR_BARO)) return sendIbusMeasurement2(address, (uint16_t) ((DEGREES_TO_CENTIDEGREES(getCurrentTemperature()) + 50) / 10  + IBUS_TEMPERATURE_OFFSET)); //int32_t*/


If I can suggest, it can be:

int16_t temperature; if (sensors(SENSOR_BARO)) { getBaroTemperature(&temperature); } else { getMPUTemperature(&temperature); } return sendIbusMeasurement2(address, (uint16_t) ((temperature + 50) / 10 + IBUS_TEMPERATURE_OFFSET));

Why not, done, it now reports baro temp if available, IMU temp otherwise

hali9 · 2019-02-02T12:53:15Z

src/main/telemetry/ibus_shared.c

-        }
+        int16_t temperature;
+        const bool temp_valid = sensors(SENSOR_BARO) ? getBaroTemperature(&temperature) : getIMUTemperature(&temperature);
+        if (!temp_valid || (temperature < -50)) temperature = -50; // Minimum reported temperature is -5°C


Not realy, ibus temperatue sensor minimum is 40 deg.
0=-40.0 C, 400=0.0 C, 65535=6513.5 C
so proposes change -50 to -400

True, I forgot about the offset

hali9 · 2019-02-02T12:53:20Z

src/main/telemetry/ibus_shared.c

+        int16_t temperature;
+        const bool temp_valid = sensors(SENSOR_BARO) ? getBaroTemperature(&temperature) : getIMUTemperature(&temperature);
+        if (!temp_valid || (temperature < -50)) temperature = -50; // Minimum reported temperature is -5°C
+        return sendIbusMeasurement2(address, (uint16_t)((temperature + 50) / 10  + IBUS_TEMPERATURE_OFFSET));


if getBaroTemperature and getIMUTemperature return temperature in decidegree (0.1) no need to be calculated
Just (uint16_t)(temperature + IBUS_TEMPERATURE_OFFSET)

Are you sure about that ?

Yes I sure.

It doesn't match the old code:

return sendIbusMeasurement2(address, (uint16_t) ((DEGREES_TO_CENTIDEGREES(getCurrentTemperature()) + 50) / 10 + IBUS_TEMPERATURE_OFFSET));

Yesterday I compiled and uploaded the code from Your branch with minimum -400 and (uint16_t)(temperature + IBUS_TEMPERATURE_OFFSET) and got the correct temperature values for both IMU and baro. For baro get -40.0 for a first second after power up.

Nice. I didn't touch the code reading the baro temperature. Not a big issue I think

src/main/blackbox/blackbox.c

digitalentity · 2019-02-02T18:22:46Z

src/main/drivers/1-wire.c

+_1WireDev_t ds2482Dev;
+#endif
+
+void _1WireInit(void)


Our convention is to use chip name as a file name and function name prefix.

digitalentity · 2019-02-02T18:25:42Z

src/main/drivers/temperature/ds18b20.c

+{
+    bool parasitic_power = ds18b20_parasitic_powered_present(_1WireDev);
+    if (parasitic_power) return false;
+    bool ack = ds2482_1wire_reset_and_skip_rom(_1WireDev);


I don't like this explicit dependency. We should either make 1-wire driver abstracted and make ds18b20 call high-level 1-wire read/write functions or merge the ds18b20 with ds2482.

digitalentity · 2019-02-02T18:26:32Z

src/main/drivers/temperature/ds18b20.c

+    return ds2482_1wire_write_byte(_1WireDev, DS18B20_START_CONVERSION_CMD);
+}
+
+bool ds18b20_wait_for_conversion()


In functions waiting for external sensor to complete the operation protothreads play quite nicely.

Yes I need to take a look into it because even though everything works fine on the bench after checking the protocol timing reading the sensor values takes too much time. The reading process will need to yield before all the sensors are read or even during addressing/reading. 1-Wire is pretty slow. Only addressing the sensor takes 7.7ms. Reading the temperature value then takes 8.1ms. So we are talking a bit less than 16ms per sensor to read back the temperature value. Fortunately we can send the "start conversion" to all the sensors at once and that only takes ~2.2ms.

Still, even 2.2ms is too much to do in one iteration. I think we should really think into making this ptThreaded eventually

Resetting the 1-Wire bus (needed before every command) is taking 1345µs in itself so it looks like we will need to. We need to send the reset command (54µs) then yield and the next iterations check if the bus has been reset (54µs) then send a new command

digitalentity · 2019-02-02T18:27:17Z

src/main/drivers/1-wire.h

+extern _1WireDev_t ds2482Dev;
+#endif
+
+void _1WireInit(void);


OneWireInit() maybe?

Ok yes I don't really like starting names with _

wx4cb · 2019-02-03T13:16:54Z

that bad data on first read is entirely possible depending on the sensor they're using. some of the stuff we have for work does the same thing at first power on takes them a couple seconds to stabilise.

…

On Sun, 3 Feb 2019 at 08:09, hali9 ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In src/main/telemetry/ibus_shared.c <#4282 (comment)>: > @@ -141,15 +141,10 @@ static uint8_t dispatchMeasurementRequest(ibusAddress_t address) { } #endif if (SENSOR_ADDRESS_TYPE_LOOKUP[address].value == IBUS_MEAS_VALUE_TEMPERATURE) { //BARO_TEMP\GYRO_TEMP - if (sensors(SENSOR_BARO)) return sendIbusMeasurement2(address, (uint16_t) ((DEGREES_TO_CENTIDEGREES(getCurrentTemperature()) + 50) / 10 + IBUS_TEMPERATURE_OFFSET)); //int32_t - else { - /* - * There is no temperature data - * assuming ((DEGREES_TO_CENTIDEGREES(getCurrentTemperature()) + 50) / 10 - * 0 degrees (no sensor) equals 50 / 10 = 5 - */ - return sendIbusMeasurement2(address, (uint16_t) (5 + IBUS_TEMPERATURE_OFFSET)); //int16_t - } + int16_t temperature; + const bool temp_valid = sensors(SENSOR_BARO) ? getBaroTemperature(&temperature) : getIMUTemperature(&temperature); + if (!temp_valid || (temperature < -50)) temperature = -50; // Minimum reported temperature is -5°C + return sendIbusMeasurement2(address, (uint16_t)((temperature + 50) / 10 + IBUS_TEMPERATURE_OFFSET)); Yesterday I compiled and uploaded the code from Your branch with minimum -400 and (uint16_t)(temperature + IBUS_TEMPERATURE_OFFSET) and got the correct temperature values for both IMU and baro. For baro get -40.0 for a first second after power up. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#4282 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABbRAbKbE3J_Y3VKNFzZMZRPxHZmG2XAks5vJt-EgaJpZM4aVksu> .

shellixyz · 2019-02-03T14:49:40Z

@wx4cb What are talking about ?

wx4cb · 2019-02-03T14:51:12Z

@shellixyz i was replying to a comment that i got theough email about -40 for a couple seconds at startup. Dunno why it appeared here im guessing it was in another thread

- Support for multiple LM75 sensors - Support for the DS18B20 sensors - CLI command temp_sensor to configure sensors - Logging of all temperature sensor values - Display of all temperature sensor values on the OSD with support for alarms - New MSP messages to query and set sensor configuration and read temperatures

digitalentity

We should have an action item to refactor it further, but in general LGTM.

ghost · 2019-02-08T23:54:10Z

@shellixyz I was going to wire up a few DS18B20's, in anticipation of the 2.1 release.
What do you have in mind for the 4.7K pull-up resistor. It will need to be an external component, when being used with a DS2482.
But will it use a pull-up resistor in the controller, when using a single sensor?

teckel12 · 2019-02-09T01:31:59Z

@kardon18 You only need one pull-up resistor. Some FC already include a pull-up resistor on the i2c pin. I'd try it without the pull-up resistor and then add one if needed.

A resistor only costs about a cent, and having a few common sizes isn't a bad idea. You could probably remove one from an old piece of electronics even. It doesn't need to be 4.7k, 1k to 10k would probably work just as well.

I need to see if the F4/F7 has internal pull-up resistors. Many microcontrollers do. I know the Arduino's Amtel ATmega328 microprocessor has the ability to activate a pull-up resistor on each pin. If the F4/F7 also has this, it could be activated via code.

ghost · 2019-02-09T02:34:52Z

I need to see if the F4/F7 does have internal pull-up resistors. Many microcontrollers do. If the F4/F7 also has this, it could be activated via code.

That's what I was wondering. If the F4/F7 does have internal pull-up resistors. Will they be used.

If not. I'll just solder a 0603 SMD resistor across the VCC and Data pins on the DS18D20. To save space and keep it tidy.

teckel12 · 2019-02-09T02:44:59Z

@kardon18 It does appear that the F4/F7 have internal pull-up resistors. As I would classify temp readings as non-critical, using the known weak internal pull-up resistors would probably be fine (although would need to be activated via software, which I don't believe is happening).

You may want to see if your FC design already includes an external resistor. Or, if you have something else already on i2c it probably has a pull-up resistor of it's own, so you don't need another.

I'd try it without and only add the resistor if it doesn't work or is unreliable.

shellixyz · 2019-02-10T12:06:43Z

@kardon18 On the I²C side some FC have pull-up resisors, some don't, you have to check on the documentation or with a multimeter. I know Matek FCs already have pull-up resistors on the I²C bus, Omnibus FCs don't. If your FC doesn't have pull-up resistors you have to add them. One for the SCL line and one for SDA to 3.3V, value between 1k and 4.7k. Higher values should work but are not recommended unless the I²C bus is very short. On the 1-Wire side you need a pull-up resistor too, same range of values between VCC and the data line. For now the 1-wire parasitic power mode isn't supported you need to wire VCC to the sensors.

shellixyz force-pushed the temp_sensors_improvements branch 3 times, most recently from 2b2b3b0 to 59f64b2 Compare January 28, 2019 12:55

shellixyz force-pushed the temp_sensors_improvements branch from 59f64b2 to 00d484e Compare January 28, 2019 13:31

shellixyz force-pushed the temp_sensors_improvements branch from 00d484e to 3a83118 Compare January 29, 2019 02:40

shellixyz force-pushed the temp_sensors_improvements branch from 3a83118 to 2ce4cb8 Compare January 31, 2019 00:43

hali9 reviewed Feb 1, 2019

View reviewed changes

shellixyz force-pushed the temp_sensors_improvements branch 6 times, most recently from 28cec6f to 11bda67 Compare February 2, 2019 12:39

hali9 reviewed Feb 2, 2019

View reviewed changes

shellixyz force-pushed the temp_sensors_improvements branch from 342d52e to 8e12f12 Compare February 2, 2019 14:02

shellixyz mentioned this pull request Feb 2, 2019

Temperature sensors support iNavFlight/inav-configurator#670

Merged

digitalentity requested changes Feb 2, 2019

View reviewed changes

shellixyz force-pushed the temp_sensors_improvements branch from 8e12f12 to b0cca40 Compare February 3, 2019 09:36

shellixyz added this to the 2.1 milestone Feb 3, 2019

shellixyz mentioned this pull request Feb 3, 2019

Gyro temperature element in OSD #3978

Merged

shellixyz force-pushed the temp_sensors_improvements branch from 07d10e0 to 63a0a8f Compare February 7, 2019 22:33

shellixyz added 7 commits February 7, 2019 23:45

Add 1-Wire support through the DS2482 IF chip

f28befe

Add driver for the DS18B20 1-Wire temperature sensors

f9295dd

Enable 1-Wire and DS18B20 temp sensors on all F4 and F7 targets

2861716

Couple fixes

d63ef61

Add generic 1-Wire interface, use camel case and clean DS18B20 driver

820a852

Use ptThreads for reading temp sensors

4c33402

shellixyz force-pushed the temp_sensors_improvements branch from 63a0a8f to 4c33402 Compare February 7, 2019 22:46

shellixyz added 4 commits February 8, 2019 01:35

1-Wire add macros

5f32394

DS18B20 delay tweak

690f7e0

ds2482OwMatchRomCommand fix

e64adca

DS18B20 factorize

e9b65b1

digitalentity approved these changes Feb 8, 2019

View reviewed changes

digitalentity merged commit 1dbc1a4 into iNavFlight:development Feb 8, 2019

MrD-RC mentioned this pull request Dec 24, 2024

DS18B20 Temp sensors still not detected in 8.0 #10551

Open

Temp sensors improvements #4282

Temp sensors improvements #4282

Conversation

shellixyz commented Jan 28, 2019 • edited Loading

ghost commented Jan 28, 2019 • edited by ghost Loading

wx4cb commented Jan 28, 2019 via email

shellixyz commented Jan 28, 2019

ghost commented Jan 29, 2019 • edited by ghost Loading

wx4cb commented Jan 29, 2019 via email

shellixyz commented Jan 29, 2019

fiam commented Jan 29, 2019

ghost commented Jan 30, 2019

shellixyz commented Jan 30, 2019

ghost commented Jan 30, 2019 • edited by ghost Loading

shellixyz commented Jan 30, 2019

wx4cb commented Jan 30, 2019 via email

shellixyz commented Jan 30, 2019

wx4cb commented Jan 31, 2019

shellixyz commented Jan 31, 2019

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hali9 Feb 2, 2019 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

wx4cb commented Feb 3, 2019 via email

shellixyz commented Feb 3, 2019

wx4cb commented Feb 3, 2019

digitalentity left a comment

Choose a reason for hiding this comment

ghost commented Feb 8, 2019 • edited by ghost Loading

teckel12 commented Feb 9, 2019 • edited Loading

ghost commented Feb 9, 2019

teckel12 commented Feb 9, 2019

shellixyz commented Feb 10, 2019 • edited Loading

shellixyz commented Jan 28, 2019 •

edited

Loading

ghost commented Jan 28, 2019 •

edited by ghost

Loading

ghost commented Jan 29, 2019 •

edited by ghost

Loading

ghost commented Jan 30, 2019 •

edited by ghost

Loading

hali9 Feb 2, 2019 •

edited

Loading

ghost commented Feb 8, 2019 •

edited by ghost

Loading

teckel12 commented Feb 9, 2019 •

edited

Loading

shellixyz commented Feb 10, 2019 •

edited

Loading