Use osdDisplayPIDValues() to draw pitch and roll PIDs #3409
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves 384 bytes of flash in F3
|
@shellixyz Take a look at this one, please. |
|
Unfortunately it won't work correctly. The PID factors for pitch and roll can be adjusted simultaneously (ADJUSTMENT_PITCH_ROLL_P, ADJUSTMENT_PITCH_ROLL_I, ADJUSTMENT_PITCH_ROLL_D). With this mod the PID factors won't blink when pitch and roll are adjusted simultaneously. We could do this: shellixyz@6a7ea1b. Still saves 320 bytes. I updated the commit I made a mistake. |
|
@shellixyz Thanks! I've cherry-picked your commit and added it to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves 320 bytes of flash in F3