Adjust SW blink interval #9644
Merged
Adjust SW blink interval #9644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200ms seems to iteract badly with some digital systems, causing unreliable blinking. I will turn the cycle interval into a configuration variable in 8.0. 200ms = original value, unreliable blinking 500ms = acceptable blinking with walksnail 1000ms = was also tested and worked ok For software blink emulation, Blinking changes a character appearance at a given frequency, the OSD code on digital systems updates the OSD at a different arbitrary frequency. Depending on the relationship between the two you may not see the text, or it may not blink. Similar to how lights can blink if you have mismatched frequencies when recording video (50Hz mains, 60fps video). I also suspect that the way some of the digital systems handle blinking characters may rely on the clear screen command, which also happens at a given frequency in INAV.
Looks like display.c already handles it, and displayport_msp is always using sw blinking.
|
@mmosca This change has made it more consistent. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
200ms seems to iteract badly with some digital systems, causing unreliable blinking.
I will turn the cycle interval into a configuration variable in 8.0.
200ms = original value, unreliable blinking
500ms = acceptable blinking with walksnail
1000ms = was also tested and worked ok
For software blink emulation, Blinking changes a character appearance at a given frequency, the OSD code on digital systems updates the OSD at a different arbitrary frequency. Depending on the relationship between the two you may not see the text, or it may not blink. Similar to how lights can blink if you have mismatched frequencies when recording video (50Hz mains, 60fps video).
I also suspect that the way some of the digital systems handle blinking characters may rely on the clear screen command, which also happens at a given frequency in INAV.
This is a temporary workaround for #9552
I will make the value configurable in INAV 8.0