Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust SW blink interval #9644

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Commits on Jan 14, 2024

  1. Adjust SW blink interval

    200ms seems to iteract badly with some digital systems, causing
    unreliable blinking.
    
    I will turn the cycle interval into a configuration variable in 8.0.
    
    200ms = original value, unreliable blinking
    500ms = acceptable blinking with walksnail
    1000ms = was also tested and worked ok
    
    For software blink emulation, Blinking changes a character appearance
    at a given frequency, the OSD code on digital systems updates the OSD at a
    different arbitrary frequency. Depending on the relationship between the two
    you may not see the text, or it may not blink. Similar to how lights can
    blink if you have mismatched frequencies when recording video (50Hz
    mains, 60fps video).
    
    I also suspect that the way some of the digital systems handle blinking characters
    may rely on the clear screen command, which also happens at a given
    frequency in INAV.
    mmosca committed Jan 14, 2024
    Configuration menu
    Copy the full SHA
    15fbe0d View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2024

  1. Remove blink handling from displayport_msp

    Looks like display.c already handles it,
    and displayport_msp is always using sw blinking.
    mmosca committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    dd7404b View commit details
    Browse the repository at this point in the history