grep variables from ini file #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jomey
approved these changes
Oct 31, 2025
| # Extract variables from ini file. | ||
| START_DATE=$(grep -E '^start_date' "$KATANA_INI" | cut -d':' -f2 | awk '{$1=$1;print}') | ||
| START_YEAR=$(echo "$START_DATE" | cut -d'-' -f1) | ||
| START_MONTH=$(echo "$START_DATE" | cut -d'-' -f2) |
Member
There was a problem hiding this comment.
Minor suggestion to make these calls a little simpler and have you tried to use a date parse to get to year and month. Pseudo code:
year=$(date -d "$START_DATE" +%Y)
month=$(date -d "$START_DATE" +%m)
Member
|
❤️ - Thanks for this improvement |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #8 by calling variables directly from Katana INI file (so users don't need to repeat inputs here).
This implementation is slightly sensitive to having dates structured with dashes. Although with these types of things I would assume a user would simply follow the template, which is very clear and contained within this repo. @jomey if you have any other strategies for pulling happy to make any changes here.