Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mitigate GHSA-qwcr-r2fm-qrc7 #7146

Merged
merged 6 commits into from
Sep 12, 2024
Merged

Conversation

ben-polinsky
Copy link
Contributor

@ben-polinsky ben-polinsky commented Sep 11, 2024

Handle audit failures:
body-parser: GHSA-qwcr-r2fm-qrc7
path-to-regexp: GHSA-9wv6-86v2-598j

Packages updated:
sinon -> ^18.0.1
body-parser -> ^1.20.3
express -> ^4.20.0
fetch-mock -> ~11.1.3

Working with @tcobbs-bentley to resolve the failing ios tests after upgrade. Seems to be a unicode issue related to this change in path-to-regexp. Working theory (from Travis):

it looks like both ID_Start and ID_Continue are special regex tokens. I found the following, and I'm not sure if it's related or not: https://stackoverflow.com/questions/71155109/invalid-regular-expression-invalid-property-name-in-character-class. Digging further, it looks like this regex will only work with full ICU (International Components for Unicode). The mobile build of Node does not have this (and probably cannot have it any time soon).

Also upgrade actions/upload-artifact@v2 -> actions/upload-artifact@v4 since v2 is no longer supported. This task is used in our extract-api action.

We'll get this through to unblock builds and take another look tomorrow.

@ben-polinsky ben-polinsky enabled auto-merge (squash) September 11, 2024 17:10
@ben-polinsky ben-polinsky changed the title upgrade various vulnerable dependencies mitigate GHSA-qwcr-r2fm-qrc7 Sep 11, 2024
@aruniverse aruniverse merged commit 9f4c8a4 into master Sep 12, 2024
16 checks passed
@aruniverse aruniverse deleted the mitigate-various-audit-failures branch September 12, 2024 01:12
@hl662
Copy link
Contributor

hl662 commented Sep 12, 2024

@Mergifyio backport release/4.8.x

Copy link
Contributor

mergify bot commented Sep 12, 2024

backport release/4.8.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Sep 12, 2024
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com>
(cherry picked from commit 9f4c8a4)

# Conflicts:
#	common/config/rush/pnpm-config.json
#	common/config/rush/pnpm-lock.yaml
#	full-stack-tests/rpc/package.json
hl662 pushed a commit that referenced this pull request Sep 13, 2024
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com>
naronchen pushed a commit that referenced this pull request Sep 27, 2024
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com>
naronchen pushed a commit that referenced this pull request Sep 30, 2024
Co-authored-by: Ben Polinsky <ben-polinsky@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants