-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mitigate GHSA-qwcr-r2fm-qrc7 (backport #7146) [release/4.8.x] #7155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mergify
bot
requested review from
a team,
aruniverse,
mdastous-bentley,
eringram and
calebmshafer
as code owners
September 12, 2024 21:17
Cherry-pick of 9f4c8a4 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
mergify
bot
requested review from
ben-polinsky,
a team,
danieliborra,
paulius-valiunas,
wgoehrig,
christophermlawson and
StefanApfel-Bentley
as code owners
September 12, 2024 21:17
aruniverse
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle audit failures:
body-parser
: GHSA-qwcr-r2fm-qrc7path-to-regexp
: GHSA-9wv6-86v2-598jPackages updated:
sinon
->^18.0.1
body-parser
->^1.20.3
express
->^4.20.0
fetch-mock
->~11.1.3
Working with @tcobbs-bentley to resolve the failing ios tests after upgrade. Seems to be a unicode issue related to this change in path-to-regexp. Working theory (from Travis):
Also upgrade actions/upload-artifact@v2 -> actions/upload-artifact@v4 since v2 is no longer supported. This task is used in our extract-api action.
We'll get this through to unblock builds and take another look tomorrow.
This is an automatic backport of pull request #7146 done by [Mergify](https://mergify.com).