Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release packages [publish docs] #674

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

imodeljs-admin
Copy link
Collaborator

@imodeljs-admin imodeljs-admin commented Jul 12, 2024

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

@itwin/presentation-hierarchies@0.4.0

Minor Changes

  • #676: createHierarchyProvider: Added ability to specify whether hierarchy should be expanded to filtering path target, when specifying the filtering.paths prop.

    With this change, hierarchy is no longer expanded to filter targets by default. To achieve the same behavior, paths with autoExpand option should be provided:

    Before:

    const hierarchyProvider = createHierarchyProvider({
      imodelAccess,
      hierarchyDefinition: createHierarchyDefinition(imodelAccess),
      filtering: { paths: filterPaths },
    });

    Now:

    const hierarchyProvider = createHierarchyProvider({
      imodelAccess,
      hierarchyDefinition: createHierarchyDefinition(imodelAccess),
      filtering: { paths: filterPaths.map((path) => ({ path, options: { autoExpand: true } })) },
    });
  • #672: Fix autoExpand prop of grouping specification for NodesQueryClauseFactory.createSelectClause being wrongly defined as string. Define it as a string union of "always" | "single-child".

Patch Changes

  • #675: Fix nodes being erroneously set as filter targets when they had filter target siblings.
  • #672: Fix grouped nodes not being returned for "Not specified" property grouping node when grouping by value ranges.
  • #672: Fix hierarchy provider not returning all nodes in situations when internal cache is full and a prior request of grouped children was made.
  • Updated dependencies:
    • @itwin/presentation-shared@0.4.0

@itwin/presentation-hierarchies-react@0.7.0

Minor Changes

  • #676: useTree and useUnifiedSelectionTree: Extended return type of getFilteredPaths prop to allow specifying whether hierarchy should be expanded to filtering path target.

    With this change, hierarchy is no longer expanded to filter targets by default. To achieve the same behavior, paths with autoExpand option should be returned:

    Before:

    async function getFilteredPaths(): Promise<HierarchyNodeIdentifiersPath[]> {
      return paths;
    }

    Now:

    async function getFilteredPaths(): Promise<Array<{ path: HierarchyNodeIdentifiersPath; options?: { autoExpand?: boolean }>> {
      return paths.map((path) => ({ path, options: { autoExpand: true } }));
    }

Patch Changes

  • Updated dependencies:
    • @itwin/presentation-hierarchies@0.4.0
    • @itwin/presentation-shared@0.4.0
    • @itwin/unified-selection@0.4.6

@itwin/presentation-shared@0.4.0

Minor Changes

  • #675: Added an utility ECSql.createInstanceKeySelector function to simplify selecting InstanceKey objects.

    Example usage:

    const reader = queryExecutor.createQueryReader({
      ecsql: `
        SELECT ${ECSql.createInstanceKeySelector("el")} key
        FROM bis.Element el
      `,
    });
    for await (const row of reader) {
      const instanceKey: InstanceKey = JSON.parse(row.key);
      // do something with instanceKey
    }

@itwin/presentation-components@5.4.1

Patch Changes

  • #683: Added tree reloading when changes to the briefcase are applied in useTreeReload.
  • #684: Disabled property editors from propagating key down events.
  • #687: Updated NumericPropertyEditor to use raw values instead of display values.

@itwin/presentation-core-interop@0.2.5

Patch Changes

  • Updated dependencies:
    • @itwin/presentation-shared@0.4.0

@itwin/presentation-testing@5.0.15

Patch Changes

  • Updated dependencies:
    • @itwin/presentation-components@5.4.1

@itwin/unified-selection@0.4.6

Patch Changes

  • Updated dependencies:
    • @itwin/presentation-shared@0.4.0

@imodeljs-admin imodeljs-admin requested a review from a team as a code owner July 12, 2024 06:27
Copy link

github-actions bot commented Jul 12, 2024

Hierarchies benchmark

Benchmark suite Current: 56c3478 Previous: 28e928e Deviation Status
flat 50k elements list 4082.32 ms 4069.09 ms 0.3251% 🚨
flat 50k elements list (P95 of main thread blocks) 75 ms 71 ms 5.6338% 🚨
grouping by label 10010.16 ms 9956.66 ms 0.5373% 🚨
grouping by label (P95 of main thread blocks) 65 ms 63 ms 3.1746% 🚨
grouping by class 10175.15 ms 9985.85 ms 1.8957% 🚨
grouping by class (P95 of main thread blocks) 46 ms 45 ms 2.2222% 🚨
grouping by property 10609.67 ms 10562.86 ms 0.4432% 🚨
grouping by property (P95 of main thread blocks) 50 ms 83 ms -39.7590%
grouping by base class (10 classes) 7336.26 ms 7328.7 ms 0.1032% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 81 ms 81 ms 0% 🟰
grouping by multiple attributes 27112.11 ms 26834.65 ms 1.0340% 🚨
grouping by multiple attributes (P95 of main thread blocks) 56 ms 50 ms 12% 🚨
hide if no children required to finalize root, w/o children 46599.06 ms 46154.01 ms 0.9643% 🚨
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 39 ms 41 ms -4.8780%
hide if no children required to finalize root, w/ children 156.03 ms 155.21 ms 0.5283% 🚨
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 42.92 ms 38.98 ms 10.1077% 🚨
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7690.27 ms 7613.94 ms 1.0025% 🚨
models tree full (Baytown) (P95 of main thread blocks) 92 ms 89 ms 3.3708% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@imodeljs-admin imodeljs-admin force-pushed the changeset-release/master branch 2 times, most recently from 2ae32d9 to 9121579 Compare July 15, 2024 12:05
Copy link

github-actions bot commented Jul 15, 2024

Unified selection benchmark

Benchmark suite Current: 56c3478 Previous: 28e928e Deviation Status
hilite 50k elements 1258.67 ms 1312.32 ms -4.0882%
hilite 50k elements (P95 of main thread blocks) 46 ms 47 ms -2.1277%
hilite 50k group elements 231.88 ms 235.46 ms -1.5204%
hilite 50k group elements (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 1k subjects 47748.58 ms 47986.01 ms -0.4948%
hilite 1k subjects (P95 of main thread blocks) 23 ms 28 ms -17.8571%
hilite 50k subcategories 274.35 ms 276.61 ms -0.8170%
hilite 50k subcategories (P95 of main thread blocks) 33 ms 33 ms 0% 🟰
hilite 50k functional 3D elements 25460.45 ms 25501.28 ms -0.1601%
hilite 50k functional 3D elements (P95 of main thread blocks) 34 ms 38 ms -10.5263%
hilite 50k functional 2D elements 6206.1 ms 6095.93 ms 1.8073% 🚨
hilite 50k functional 2D elements (P95 of main thread blocks) 38 ms 36 ms 5.5556% 🚨
compute selection for 50k elements 317.94 ms 343.92 ms -7.5541%
compute selection for 50k elements (P95 of main thread blocks) 31 ms 34 ms -8.8235%
compute parent selection for 50k elements 377.67 ms 338.11 ms 11.7003% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 35 ms 31 ms 12.9032% 🚨
compute top ancestor selection for 50k elements 558.99 ms 564.28 ms -0.9375%
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 94.07 ms 92.09 ms 2.1501% 🚨
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 74.2 ms 77.52 ms -4.2828%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 440.51 ms 405.36 ms 8.6713% 🚨
compute functional selection for 50k 3D elements (P95 of main thread blocks) 38 ms 31 ms 22.5806% 🚨
compute parent functional selection for 50k 3D elements 440.21 ms 436.42 ms 0.8684% 🚨
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1153.26 ms 1147.04 ms 0.5423% 🚨
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3015.73 ms 2987.63 ms 0.9405% 🚨
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 2956.62 ms 2979.94 ms -0.7826%
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3000.1 ms 3046.12 ms -1.5108%
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@imodeljs-admin imodeljs-admin force-pushed the changeset-release/master branch 6 times, most recently from 20d3e51 to 2aa419c Compare July 22, 2024 06:28
@imodeljs-admin imodeljs-admin force-pushed the changeset-release/master branch from 2aa419c to 24c0d24 Compare July 25, 2024 12:54
@imodeljs-admin imodeljs-admin force-pushed the changeset-release/master branch from 24c0d24 to 56c3478 Compare July 25, 2024 13:30
@saskliutas saskliutas merged commit 847e2f7 into master Jul 29, 2024
11 checks passed
@saskliutas saskliutas deleted the changeset-release/master branch July 29, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants