Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hierarchies: Add a learning page for hierarchy filtering #675

Merged
merged 6 commits into from
Jul 15, 2024

Conversation

grigasp
Copy link
Member

@grigasp grigasp commented Jul 12, 2024

Part of #423

@grigasp grigasp requested a review from a team as a code owner July 12, 2024 13:25
Copy link

changeset-bot bot commented Jul 12, 2024

🦋 Changeset detected

Latest commit: 251b067

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@itwin/presentation-shared Minor
@itwin/presentation-hierarchies Patch
@itwin/presentation-core-interop Patch
@itwin/presentation-hierarchies-react Patch
@itwin/unified-selection Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@grigasp grigasp enabled auto-merge (squash) July 12, 2024 13:26
Copy link

github-actions bot commented Jul 12, 2024

Unified selection benchmark

Benchmark suite Current: 251b067 Previous: f76a4f2 Deviation Status
hilite 50k elements 1218.12 ms 1238.41 ms -1.6384%
hilite 50k elements (P95 of main thread blocks) 47 ms 43 ms 9.3023% 🚨
hilite 50k group elements 243.23 ms 236.07 ms 3.0330% 🚨
hilite 50k group elements (P95 of main thread blocks) 31 ms 33 ms -6.0606%
hilite 1k subjects 47469.75 ms 47796.35 ms -0.6833%
hilite 1k subjects (P95 of main thread blocks) 23 ms 28 ms -17.8571%
hilite 50k subcategories 274.23 ms 277.92 ms -1.3277%
hilite 50k subcategories (P95 of main thread blocks) 33 ms 34 ms -2.9412%
hilite 50k functional 3D elements 25449.52 ms 25578.8 ms -0.5054%
hilite 50k functional 3D elements (P95 of main thread blocks) 39 ms 33 ms 18.1818% 🚨
hilite 50k functional 2D elements 6094.01 ms 6096.07 ms -0.0338%
hilite 50k functional 2D elements (P95 of main thread blocks) 32 ms 34 ms -5.8824%
compute selection for 50k elements 318.91 ms 361.57 ms -11.7985%
compute selection for 50k elements (P95 of main thread blocks) 31 ms 36 ms -13.8889%
compute parent selection for 50k elements 370.21 ms 338.65 ms 9.3194% 🚨
compute parent selection for 50k elements (P95 of main thread blocks) 35 ms 32 ms 9.3750% 🚨
compute top ancestor selection for 50k elements 575.42 ms 557.87 ms 3.1459% 🚨
compute top ancestor selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute category selection for 50k elements 89.03 ms 95.42 ms -6.6967%
compute category selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute model selection for 50k elements 74 ms 81.93 ms -9.6790%
compute model selection for 50k elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 3D elements 401.9 ms 408.28 ms -1.5627%
compute functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute parent functional selection for 50k 3D elements 455.47 ms 445.02 ms 2.3482% 🚨
compute parent functional selection for 50k 3D elements (P95 of main thread blocks) 31 ms 31 ms 0% 🟰
compute top ancestor functional selection for 50k 3D elements 1219.78 ms 1174.41 ms 3.8632% 🚨
compute top ancestor functional selection for 50k 3D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute functional selection for 50k 2D elements 3148.72 ms 3074.13 ms 2.4264% 🚨
compute functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute parent functional selection for 50k 2D elements 3127.28 ms 3022.34 ms 3.4721% 🚨
compute parent functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
compute top ancestor functional selection for 50k 2D elements 3207.58 ms 3099.19 ms 3.4974% 🚨
compute top ancestor functional selection for 50k 2D elements (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

github-actions bot commented Jul 12, 2024

Hierarchies benchmark

Benchmark suite Current: 251b067 Previous: 71f5aeb Deviation Status
flat 50k elements list 4057.7 ms 4096.42 ms -0.9452%
flat 50k elements list (P95 of main thread blocks) 71 ms 72 ms -1.3889%
grouping by label 9842.15 ms 9892.7 ms -0.5110%
grouping by label (P95 of main thread blocks) 60 ms 57 ms 5.2632% 🚨
grouping by class 9937.05 ms 9996.91 ms -0.5988%
grouping by class (P95 of main thread blocks) 46 ms 45 ms 2.2222% 🚨
grouping by property 10505.68 ms 10548.78 ms -0.4086%
grouping by property (P95 of main thread blocks) 44 ms 43 ms 2.3256% 🚨
grouping by base class (10 classes) 7374.6 ms 7327.75 ms 0.6394% 🚨
grouping by base class (10 classes) (P95 of main thread blocks) 80 ms 78 ms 2.5641% 🚨
grouping by multiple attributes 26713.65 ms 26951.49 ms -0.8825%
grouping by multiple attributes (P95 of main thread blocks) 65 ms 53 ms 22.6415% 🚨
hide if no children required to finalize root, w/o children 45005.8 ms 46498.83 ms -3.2109%
hide if no children required to finalize root, w/o children (P95 of main thread blocks) 38 ms 37 ms 2.7027% 🚨
hide if no children required to finalize root, w/ children 153.37 ms 157.59 ms -2.6778%
hide if no children required to finalize root, w/ children (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree initial (Baytown) 38.74 ms 41.45 ms -6.5380%
models tree initial (Baytown) (P95 of main thread blocks) 0 ms 0 ms NaN% 🚨
models tree full (Baytown) 7587.16 ms 7616.68 ms -0.3876%
models tree full (Baytown) (P95 of main thread blocks) 88 ms 85 ms 3.5294% 🚨

This comment was automatically generated by workflow using github-action-benchmark.

@grigasp grigasp merged commit 01dce3e into master Jul 15, 2024
9 checks passed
@grigasp grigasp deleted the hierarchies/learning/hierarchy-filtering branch July 15, 2024 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants