Skip to content

Commit

Permalink
fix: Initialize EnvDescriber in init command for svc and job (aws#4253)
Browse files Browse the repository at this point in the history
This PR will fix the failing test suite i.e, to initialize EnvDescriber for both service and job in init 


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the Apache 2.0 License.
  • Loading branch information
KollaAdithya committed Dec 6, 2022
1 parent dfde4db commit 9e4983a
Showing 1 changed file with 23 additions and 0 deletions.
23 changes: 23 additions & 0 deletions internal/pkg/cli/init.go
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import (

awscfn "github.com/aws/copilot-cli/internal/pkg/aws/cloudformation"
"github.com/aws/copilot-cli/internal/pkg/aws/iam"
"github.com/aws/copilot-cli/internal/pkg/describe"
"github.com/aws/copilot-cli/internal/pkg/docker/dockerfile"

"github.com/aws/copilot-cli/internal/pkg/deploy"
Expand Down Expand Up @@ -264,6 +265,17 @@ func newInitOpts(vars initVars) (*initOpts, error) {
initParser: func(s string) dockerfileParser {
return dockerfile.New(fs, s)
},
initEnvDescriber: func(appName string, envName string) (envDescriber, error) {
envDescriber, err := describe.NewEnvDescriber(describe.NewEnvDescriberConfig{
App: appName,
Env: envName,
ConfigStore: configStore,
})
if err != nil {
return nil, fmt.Errorf("initiate env describer: %w", err)
}
return envDescriber, nil
},
}
o.initWlCmd = &opts
o.schedule = &opts.schedule // Surfaced via pointer for logging
Expand Down Expand Up @@ -292,6 +304,17 @@ func newInitOpts(vars initVars) (*initOpts, error) {
opts.df = dockerfile.New(opts.fs, opts.dockerfilePath)
return opts.df
}
opts.initEnvDescriber = func(appName string, envName string) (envDescriber, error) {
envDescriber, err := describe.NewEnvDescriber(describe.NewEnvDescriberConfig{
App: appName,
Env: envName,
ConfigStore: opts.store,
})
if err != nil {
return nil, fmt.Errorf("initiate env describer: %w", err)
}
return envDescriber, nil
}
o.initWlCmd = &opts
o.port = &opts.port // Surfaced via pointer for logging.
o.initWkldVars = &opts.initWkldVars
Expand Down

0 comments on commit 9e4983a

Please sign in to comment.