Fix onDragStart callback dependency on 'readonly' (#4707)

* fix: add 'readonly' dependency for onDragStart callback * add changeset
ianstormtaylor · Dec 4, 2021 · c020ca2 · c020ca2
1 parent 6d19407
commit c020ca2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/.changeset/hungry-dingos-do.md b/.changeset/hungry-dingos-do.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+fix: add 'readonly' dependency for onDragStart callback
diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
@@ -936,7 +936,7 @@ export const Editable = (props: EditableProps) => {
                 ReactEditor.setFragmentData(editor, event.dataTransfer)
               }
             },
-            [attributes.onDragStart]
+            [readOnly, attributes.onDragStart]
           )}
           onDrop={useCallback(
             (event: React.DragEvent<HTMLDivElement>) => {