Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix onDragStart callback dependency on 'readonly' #4707

Merged
merged 2 commits into from
Dec 4, 2021

Conversation

ahoisl
Copy link
Contributor

@ahoisl ahoisl commented Dec 2, 2021

Description
PR #4617 fixed a bug by checking readOnly in the onDragStart callback, but missed setting the dependency on useCallback. Consequently, if you have an editable that switches from readonly to not-readonly, the drag event will not add the internal fragment and the drop will fallback to plain text (because the fragment is not there).

Issue
related to #4548

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Dec 2, 2021

🦋 Changeset detected

Latest commit: 72c2dbc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit c020ca2 into ianstormtaylor:main Dec 4, 2021
@github-actions github-actions bot mentioned this pull request Dec 4, 2021
@ahoisl ahoisl deleted the FixOnDragStartReadonlyDep branch December 4, 2021 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants