Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on drag and drop image on readOnly editable #4617

Merged
merged 2 commits into from
Oct 22, 2021

Conversation

imdbsd
Copy link
Contributor

@imdbsd imdbsd commented Oct 22, 2021

Description
when readonly, onDragStart function should not be called since it will mutate the document.

Issue
Fixes: #4548

Example
https://user-images.githubusercontent.com/16449020/138408160-c7ce17db-65cf-4d9b-9f55-c8d907b96bac.mp4

Context

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

@changeset-bot
Copy link

changeset-bot bot commented Oct 22, 2021

🦋 Changeset detected

Latest commit: f3fedb9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dylans dylans merged commit b186d3e into ianstormtaylor:main Oct 22, 2021
@imdbsd imdbsd deleted the fix/readonly-void-drag branch October 24, 2021 12:01
@ahoisl
Copy link
Contributor

ahoisl commented Dec 2, 2021

This fix causes DnD to not insert fragments any more after switching an Editable from readonly to not-readonly

Reason: the onDragStart useCallback dependencies are missing the "readonly" property. I will open a PR soon...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It crashes if I drag an image into text in readOnly mode
3 participants