Fix editor.insertText never gets called inside plugins on Android (#4753

) * Call Editor.insertText instead of Transforms.insertText to allow overriding by plugins * Use Editor.insertText in android-input-manager * changeset
ianstormtaylor · Jan 4, 2022 · e9a46ad · e9a46ad
1 parent 735d2d0
commit e9a46ad
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 7 deletions.
diff --git a/.changeset/breezy-ears-happen.md b/.changeset/breezy-ears-happen.md
@@ -0,0 +1,5 @@
+---
+'slate-react': patch
+---
+
+Fix "editor.insertText never gets called inside plugins on android"
diff --git a/packages/slate-react/src/components/android/android-editable.tsx b/packages/slate-react/src/components/android/android-editable.tsx
@@ -560,9 +560,7 @@ export const AndroidEditable = (props: EditableProps): JSX.Element => {
                       })
                       editor.marks = null
                     } else {
-                      Transforms.insertText(editor, text, {
-                        at,
-                      })
+                      Editor.insertText(editor, text)
                     }
                   })
                 }, RESOLVE_DELAY)

diff --git a/packages/slate-react/src/components/android/android-input-manager.ts b/packages/slate-react/src/components/android/android-input-manager.ts
@@ -134,9 +134,7 @@ export class AndroidInputManager {
         })
         this.editor.marks = null
       } else {
-        Transforms.insertText(this.editor, text, {
-          at,
-        })
+        Editor.insertText(this.editor, text)
       }
     })
   }

diff --git a/packages/slate-react/src/components/editable.tsx b/packages/slate-react/src/components/editable.tsx
@@ -793,7 +793,7 @@ export const Editable = (props: EditableProps) => {
                         distance: currentTextNode.text.length,
                         reverse: true,
                       })
-                      Transforms.insertText(editor, text)
+                      Editor.insertText(editor, text)
                     })
                   }
                 }