Fix editor.insertText never gets called inside plugins on Android

[alessiogaldy]

Description
Call editor.insertText instead of Transforms.insertText to allow overriding behavior in plugins.

Issue
Fixes: #4709
I was able to verify that this now works correctly on my Android device, but I am not sure how to add a test for this.

Checks

• The new code matches the existing patterns and styles.
• The tests pass with yarn test.
• The linter passes with yarn lint. (Fix errors with yarn fix.)
• The relevant examples still work. (Run examples with yarn start.)
• You've added a changeset if changing functionality. (Add one with yarn changeset add.)

[changeset-bot]

🦋 Changeset detected

Latest commit: 5880553

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
slate-react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[dylans]

Thanks @alessiogaldy , I will land this sometime in the next few days unless there are objections.

[TheSpyder]

This code was added in #4734 and appears to very specifically not call Editor.insertText in order to adjust the at position. I don't have an Android device so I don't really understand the scenario where this might happen. We probably need @YasinChan's input here.

[YasinChan]

Hi @TheSpyder~
Code in android-editable.tsx is mine, but it came from Code in android-input-manager.ts. So I didn't pay much attention to the difference between Editor.insertText and Transforms.insertText at that time.

[TheSpyder]

Ah, my apologies.

It looks like that code originally came from #4257:
a93c555

@clauderic, are you able to provide any insights here?

[alessiogaldy]

I’ll test this again later today but I suspect that this caused a regression and now the text is inserted at the wrong position

[alessiogaldy]

I checked, and it looks like setting at is needed because this function adjusts the location before inserting the text:

slate/packages/slate-react/src/components/android/diff-text.ts

Line 161 in 1b0e7c6

export function normalizeTextInsertionRange(

I was able to obtain the same behavior by replacing the Transforms.insertText call with:

Transforms.setSelection(editor, at)
Editor.insertText(editor, text)

I am not sure if this is a good idea, but it seems to work.
I think a cleaner solution would be to allow for an optional to parameter to be passed to Editor.insertText so that it can be passed down to Transforms.insertText. Unfortunately that would require all existing plugins to pass the new argument down the chain.
It might make sense to change every function of the Editor interface to accept two arguments, the editor and an object with all other parameters. This would make adding arguments a non-breaking change in most cases because each plugin will either override the behavior or pass the object down the chain.

When testing on my phone I also noticed that when keyboard inputs are delayed, which seems to be needed to deal with edge cases on Android, the cursor sometimes jumps back and forth.
This is easier to reproduce by typing special chars like @ $.
I can reproduce this issue on the examples page so it's not a regression caused by this change (AFAIK it's not live yet).

I am happy to open a PR to add the Transforms.setSelection call and to disable the input delayed logic.

[alessiogaldy]

Reading the ProseMirror source code that is referenced in android-input-manager.ts it looks like the delay is only used for Internet Explorer <= 11 so it should be safe to remove it.