Upgrade is-plain-object to v5.0.0
#4500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499
🦋 Changeset detectedLatest commit: 6df0edf The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dylans
approved these changes
Sep 8, 2021
|
Looks fine, will land shortly. Could you please add a quick changeset (patch for each of the 4 packages) or give committers permission to edit your branch? |
Merged
dylans
added a commit
to dylans/slate
that referenced
this pull request
Sep 9, 2021
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
|
hey, sorry i didn't see your reply...had a life event happened that brought me away from OSS for a sec. thanks for adding the changeset! |
Closed
dylans
added a commit
to dylans/slate
that referenced
this pull request
Sep 13, 2021
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil
pushed a commit
to z2devil/slate
that referenced
this pull request
Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
is-plain-objectpackage recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version ofis-plain-object, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending onis-plain-object@^5.0.0and its import references across the codebase have been updated.Issue
Fixes: #4499
Example
See issue
Context
See issue
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)