-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error When Using isPlainObject v5 #4499
Labels
Comments
tubbo
added a commit
to tubbo/slate
that referenced
this issue
Sep 8, 2021
The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499
dylans
added a commit
that referenced
this issue
Sep 9, 2021
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes #4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
dylans
added a commit
to dylans/slate
that referenced
this issue
Sep 9, 2021
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
dylans
added a commit
to dylans/slate
that referenced
this issue
Sep 13, 2021
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil
pushed a commit
to z2devil/slate
that referenced
this issue
Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil
pushed a commit
to z2devil/slate
that referenced
this issue
Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0 The `is-plain-object` package recently had a major version upgrade that broke libraries which import its default export, such as this one. This causes issues when other packages in the same application require a higher version of `is-plain-object`, resulting in an error originating in Slate's codebase. To remedy this, Slate is now depending on `is-plain-object@^5.0.0` and its import references across the codebase have been updated. Fixes ianstormtaylor#4499 * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
A dependency of my application needed
is-plain-object@v5.0.0
, which changes how the function is exported (using a named export instead of the default export). This breaks the latest SlateJSRecording
See sandbox, this isn't really a visual issue it's more of an upgrade chore.
Sandbox
Not sure what I need to do here, but these dependencies should not be compatible...I'm using this same dependency set and I get an error in my application: https://codesandbox.io/s/slate-reproductions-forked-7jldg
Steps
To reproduce the behavior:
slate-react
andis-plain-object@v5.0.0
Expectation
About a week ago this was working fine. I have nailed it down to the upgrade of a dependency named
@electron-forge/publisher-github
, which I did indeed upgrade recently, which also bumped its ownis-plain-object
dependency to v5, thus we are using v5 and Slate crashes.Environment
Context
PR to fix the issue: #4500
The text was updated successfully, but these errors were encountered: