Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error When Using isPlainObject v5 #4499

Closed
tubbo opened this issue Sep 8, 2021 · 0 comments · Fixed by #4500
Closed

Error When Using isPlainObject v5 #4499

tubbo opened this issue Sep 8, 2021 · 0 comments · Fixed by #4500
Labels

Comments

@tubbo
Copy link
Contributor

tubbo commented Sep 8, 2021

Description
A dependency of my application needed is-plain-object@v5.0.0, which changes how the function is exported (using a named export instead of the default export). This breaks the latest SlateJS

Recording

See sandbox, this isn't really a visual issue it's more of an upgrade chore.

Sandbox

Not sure what I need to do here, but these dependencies should not be compatible...I'm using this same dependency set and I get an error in my application: https://codesandbox.io/s/slate-reproductions-forked-7jldg

Steps

To reproduce the behavior:

  1. Install slate-react and is-plain-object@v5.0.0
  2. Set up the editor according to the getting started guide
  3. Try to mount the editor component
  4. See error

Expectation
About a week ago this was working fine. I have nailed it down to the upgrade of a dependency named @electron-forge/publisher-github, which I did indeed upgrade recently, which also bumped its own is-plain-object dependency to v5, thus we are using v5 and Slate crashes.

Environment

  • Slate Version: v0.65.3
  • Operating System: macOS
  • Browser: Chrome (Electron)

Context
PR to fix the issue: #4500

@tubbo tubbo added the bug label Sep 8, 2021
tubbo added a commit to tubbo/slate that referenced this issue Sep 8, 2021
The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499
dylans added a commit that referenced this issue Sep 9, 2021
* Upgrade `is-plain-object` to v5.0.0

The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes #4499

* Add changeset

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
dylans added a commit to dylans/slate that referenced this issue Sep 9, 2021
* Upgrade `is-plain-object` to v5.0.0

The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499

* Add changeset

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
dylans added a commit to dylans/slate that referenced this issue Sep 13, 2021
* Upgrade `is-plain-object` to v5.0.0

The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499

* Add changeset

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil pushed a commit to z2devil/slate that referenced this issue Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0

The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499

* Add changeset

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
z2devil pushed a commit to z2devil/slate that referenced this issue Dec 6, 2024
* Upgrade `is-plain-object` to v5.0.0

The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499

* Add changeset

Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant