Skip to content

Commit

Permalink
Upgrade is-plain-object to v5.0.0
Browse files Browse the repository at this point in the history
The `is-plain-object` package recently had a major version upgrade that
broke libraries which import its default export, such as this one. This
causes issues when other packages in the same application require a
higher version of `is-plain-object`, resulting in an error originating
in Slate's codebase. To remedy this, Slate is now depending on
`is-plain-object@^5.0.0` and its import references across the codebase
have been updated.

Fixes ianstormtaylor#4499
  • Loading branch information
tubbo committed Sep 8, 2021
1 parent f5c0cbd commit 5a98f92
Show file tree
Hide file tree
Showing 14 changed files with 17 additions and 24 deletions.
2 changes: 1 addition & 1 deletion packages/slate-history/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dist/"
],
"dependencies": {
"is-plain-object": "^3.0.0"
"is-plain-object": "^5.0.0"
},
"devDependencies": {
"@babel/runtime": "^7.7.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/slate-history/src/history.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { Operation } from 'slate'

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/slate-hyperscript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"dist/"
],
"dependencies": {
"is-plain-object": "^3.0.0"
"is-plain-object": "^5.0.0"
},
"devDependencies": {
"@babel/runtime": "^7.7.4",
Expand Down
2 changes: 1 addition & 1 deletion packages/slate-hyperscript/src/hyperscript.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { Element } from 'slate'
import {
createAnchor,
Expand Down
2 changes: 1 addition & 1 deletion packages/slate-react/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
"@types/lodash": "^4.14.149",
"direction": "^1.0.3",
"is-hotkey": "^0.1.6",
"is-plain-object": "^3.0.0",
"is-plain-object": "^5.0.0",
"lodash": "^4.17.4",
"scroll-into-view-if-needed": "^2.2.20",
"tiny-invariant": "1.0.6"
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
],
"dependencies": {
"immer": "^8.0.1",
"is-plain-object": "^3.0.0",
"is-plain-object": "^5.0.0",
"tiny-warning": "^1.0.3"
},
"devDependencies": {
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/editor.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'

import {
Ancestor,
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/element.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { Editor, Node, Path, Descendant, ExtendedType, Ancestor } from '..'

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/operation.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { ExtendedType, Node, Path, Range } from '..'
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'

export type BaseInsertNodeOperation = {
type: 'insert_node'
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/point.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { produce } from 'immer'
import { ExtendedType, Operation, Path } from '..'

Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/range.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { produce } from 'immer'
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { ExtendedType, Operation, Path, Point, PointEntry } from '..'

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/interfaces/text.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'
import { Range } from '..'
import { ExtendedType } from './custom-types'
import { isDeepEqual } from '../utils/deep-equal'
Expand Down
2 changes: 1 addition & 1 deletion packages/slate/src/utils/deep-equal.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import isPlainObject from 'is-plain-object'
import { isPlainObject } from 'is-plain-object'

/*
Custom deep equal comparison for Slate nodes.
Expand Down
15 changes: 4 additions & 11 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -9191,13 +9191,6 @@ __metadata:
languageName: node
linkType: hard

"is-plain-object@npm:^3.0.0":
version: 3.0.1
resolution: "is-plain-object@npm:3.0.1"
checksum: d13fe75db350d4ac669595cdfe0242ae87fcecddf2bca858d2dd443a6ed6eb1f69951fac8c2fa85b16106c6b0d7738fea86c2aca2ecee7fd61de15c1574f2cc5
languageName: node
linkType: hard

"is-plain-object@npm:^5.0.0":
version: 5.0.0
resolution: "is-plain-object@npm:5.0.0"
Expand Down Expand Up @@ -14316,7 +14309,7 @@ resolve@^2.0.0-next.3:
resolution: "slate-history@workspace:packages/slate-history"
dependencies:
"@babel/runtime": ^7.7.4
is-plain-object: ^3.0.0
is-plain-object: ^5.0.0
lodash: ^4.17.21
slate: ^0.65.3
slate-hyperscript: ^0.62.0
Expand All @@ -14331,7 +14324,7 @@ resolve@^2.0.0-next.3:
resolution: "slate-hyperscript@workspace:packages/slate-hyperscript"
dependencies:
"@babel/runtime": ^7.7.4
is-plain-object: ^3.0.0
is-plain-object: ^5.0.0
slate: ^0.65.3
source-map-loader: ^0.2.4
peerDependencies:
Expand Down Expand Up @@ -14429,7 +14422,7 @@ resolve@^2.0.0-next.3:
"@types/react-dom": ^16.9.4
direction: ^1.0.3
is-hotkey: ^0.1.6
is-plain-object: ^3.0.0
is-plain-object: ^5.0.0
jsdom: ^16.6.0
lodash: ^4.17.4
react: ">=16.8.0"
Expand All @@ -14453,7 +14446,7 @@ resolve@^2.0.0-next.3:
dependencies:
"@babel/runtime": ^7.7.4
immer: ^8.0.1
is-plain-object: ^3.0.0
is-plain-object: ^5.0.0
lodash: ^4.17.21
slate-hyperscript: ^0.62.0
source-map-loader: ^0.2.4
Expand Down

0 comments on commit 5a98f92

Please sign in to comment.