Revert "Do NOT use exact match when updating dom selection" #4627
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change to
exactMatch: false
in #4304 was intended to fix #4293, a bug where "backwards typing" happened in nested editors.But this change has introduced at least two new bugs:
These are (IMO) worse than the original "backwards typing" bug.
Issue
Context
From discussion in #4304, the true underlying bug is in
ReactEditor.toSlateRange
. I'll attempt to fix this underlying bug instead.Checks
yarn test
.yarn lint
. (Fix errors withyarn fix
.)yarn start
.)yarn changeset add
.)