Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Do NOT use exact match when updating dom selection" #4627

Merged
merged 2 commits into from
Oct 25, 2021
Merged

Revert "Do NOT use exact match when updating dom selection" #4627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3960d09
Revert "Do NOT use exact match when updating dom selection"
jameshfisher Oct 25, 2021
9d5a5ab
changeset
jameshfisher Oct 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fair-bats-rescue.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'slate-react': patch
---

Fixed issues where cursor jumps to wrong location
2 changes: 1 addition & 1 deletion packages/slate-react/src/components/editable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ export const Editable = (props: EditableProps) => {
// If the DOM selection is in the editor and the editor selection is already correct, we're done.
if (hasDomSelection && hasDomSelectionInEditor && selection) {
const slateRange = ReactEditor.toSlateRange(editor, domSelection, {
exactMatch: false,
exactMatch: true,

// domSelection is not necessarily a valid Slate range
// (e.g. when clicking on contentEditable:false element)
Expand Down