fixed cursor when we triple click on text and type over it #4862 #4868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 661279a The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Merged
DougReeder
pushed a commit
to DougReeder/slate
that referenced
this pull request
Apr 3, 2022
…ylor#4862 (ianstormtaylor#4868) * fixed cursor when we triple click on text and type over it * fixed * fixed * Add changeset Co-authored-by: Dylan Schiemann <dylan@dojotoolkit.org>
This was referenced Oct 12, 2022
jameshfisher
added a commit
to jameshfisher/slate
that referenced
this pull request
Oct 12, 2022
…rmtaylor#5153) This reverts commit 7499d4b. The issue reported at ianstormtaylor#4862 is a valid complaint, but change in ianstormtaylor#4868 is not an appropriate fix. It is a serious breaking change, reported as bug: ianstormtaylor#5153 We should therefore revert the change. If we wish to fix Chromium's triple-click bug, we should do so by unhanging the selection when it is created; not by changing insertText behavior.
5 tasks
dylans
pushed a commit
that referenced
this pull request
Oct 12, 2022
…#5154) This reverts commit 7499d4b. The issue reported at #4862 is a valid complaint, but change in #4868 is not an appropriate fix. It is a serious breaking change, reported as bug: #5153 We should therefore revert the change. If we wish to fix Chromium's triple-click bug, we should do so by unhanging the selection when it is created; not by changing insertText behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed cursor when we triple click on text and type over it
Issue
Fixes: (bug when we triple click on text and type over it #4862)
Example
Before:
current:
Checks
yarn test.yarn lint. (Fix errors withyarn fix.)yarn start.)yarn changeset add.)