Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert insertText breaking change that deletes fragment (fixes #5153) #5154

Merged

Conversation

jameshfisher
Copy link
Contributor

Description
This reverts #4868.

The issue reported at #4862 is a valid complaint, but the change is not an appropriate fix. It is a serious breaking change, reported in #5153.

If we wish to fix Chromium's triple-click bug, we should do so by unhanging the selection when it is created; not by changing insertText behavior.

Issue
Fixes: #5153

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

…rmtaylor#5153)

This reverts commit 7499d4b.

The issue reported at ianstormtaylor#4862
is a valid complaint, but change in ianstormtaylor#4868
is not an appropriate fix. It is a serious breaking change,
reported as bug: ianstormtaylor#5153

We should therefore revert the change. If we wish to fix Chromium's
triple-click bug, we should do so by unhanging the selection when it is
created; not by changing insertText behavior.
@changeset-bot
Copy link

changeset-bot bot commented Oct 12, 2022

⚠️ No Changeset found

Latest commit: 658cd82

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dylans dylans merged commit 1b14de5 into ianstormtaylor:main Oct 12, 2022
@jameshfisher jameshfisher deleted the revert-inserttext-deletefragment branch October 12, 2022 12:38
@jameshfisher
Copy link
Contributor Author

Thanks @dylans !

@dylans dylans mentioned this pull request Oct 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serious bug: selection is already deleted before insertText is called
2 participants