Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: the 'select' parameter of the insertNodes function has been overridden #5562

Merged

Conversation

YaoKaiLun
Copy link
Contributor

@YaoKaiLun YaoKaiLun commented Nov 20, 2023

Description

The "select" parameter not works

editor.insertNodes(content, { select: false });

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: 15c9bea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@12joan
Copy link
Contributor

12joan commented Nov 21, 2023

The test:integration failures here are the same ones I'm getting in #5564. Not related to either PR.

@dylans dylans merged commit 91400a8 into ianstormtaylor:main Nov 22, 2023
10 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
@YaoKaiLun YaoKaiLun deleted the fix-insertNodes-select-overridden branch November 23, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants