Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply placeholder delay only on Android devices #5564

Merged

Conversation

12joan
Copy link
Contributor

@12joan 12joan commented Nov 21, 2023

Description
In PR #5368, a 300ms delay was added before showing the placeholder to prevent issues relating to mobile phone keyboards. This isn't great UX, and as far as I can tell (@edhager Can you confirm?) it's only needed on Android devices. This PR reduces the delay to 0ms on non-Android devices.

Example

recording.mp4

Checks

  • The new code matches the existing patterns and styles.
  • The tests pass with yarn test.
  • The linter passes with yarn lint. (Fix errors with yarn fix.)
  • The relevant examples still work. (Run examples with yarn start.)
  • You've added a changeset if changing functionality. (Add one with yarn changeset add.)

Copy link

changeset-bot bot commented Nov 21, 2023

🦋 Changeset detected

Latest commit: e7574ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
slate-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@12joan
Copy link
Contributor Author

12joan commented Nov 21, 2023

These Playwright tests fail consistently on CI, but pass for me locally.
https://github.com/ianstormtaylor/slate/actions/runs/6948575390/job/18904830308?pr=5564#step:4:15035

Same result on a branch identical to main, so not a problem with this PR.
https://github.com/12joan/slate/actions/runs/6948704391/job/18905240710#step:4:15020

@dylans dylans merged commit 9aa573e into ianstormtaylor:main Nov 22, 2023
10 of 11 checks passed
@github-actions github-actions bot mentioned this pull request Nov 22, 2023
@12joan 12joan deleted the fix/placeholder-delay-android-only branch November 22, 2023 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants