Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed PHPStan #1246

Merged
merged 1 commit into from
Apr 17, 2024
Merged

Fixed PHPStan #1246

merged 1 commit into from
Apr 17, 2024

Conversation

Steveb-p
Copy link
Contributor

Question Answer
JIRA issue N/A
Type improvement
Target version v4.6
BC breaks no
Doc needed no

Fixes PHPStan due to incoming changes from ibexa/rest#87

Checklist:

  • Provided PR description.
  • Tested the solution manually.
  • Provided automated test coverage.
  • Checked that target branch is set correctly (master for features, the oldest supported for bugs).
  • Asked for a review (ping @ibexa/engineering).

@Steveb-p Steveb-p requested a review from a team April 17, 2024 14:07
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Steveb-p Steveb-p changed the base branch from main to 4.6 April 17, 2024 14:08
@Steveb-p Steveb-p changed the title fix-phpstan Fixed PHPStan Apr 17, 2024
@mikadamczyk mikadamczyk requested a review from a team April 17, 2024 14:12
@Steveb-p Steveb-p merged commit 505ee91 into 4.6 Apr 17, 2024
23 of 24 checks passed
@Steveb-p Steveb-p deleted the fix-phpstan branch April 17, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikadamczyk mikadamczyk mikadamczyk approved these changes

@alongosz alongosz alongosz approved these changes

Assignees

@mikadamczyk mikadamczyk

@Nattfarinn Nattfarinn

@ciastektk ciastektk

@ViniTou ViniTou

Labels
Improvement Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Steveb-p @mikadamczyk @alongosz @Nattfarinn @ciastektk @ViniTou