Added proper PHPStan declaration to Ibexa\Contracts\Rest\Input\Parser::parse
#87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
konradoboza
approved these changes
Apr 17, 2024
alongosz
approved these changes
Apr 17, 2024
5 tasks
mikadamczyk
approved these changes
Apr 17, 2024
ViniTou
approved these changes
Apr 17, 2024
ciastektk
approved these changes
Apr 17, 2024
tischsoic
approved these changes
Apr 17, 2024
Steveb-p
force-pushed
the
phpstan-parser
branch
from
e8351fe to
5886c20
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related PRs:
Description:
This PR adds missing declaration for
Ibexa\Contracts\Rest\Input\Parser::parse, which will make it so it's not necessary to provide this declaration to descendants.For QA:
QA is not necessary.
Documentation:
Documentation is not necessary.