Update ServiceBindingRequests to work with latest Operator #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and causes an endless reconcile loop with the Appsody operator
And reference backing service via id field
matthewpwilson
approved these changes
Sep 9, 2020
This was referenced Sep 11, 2020
Merged
|
@matthewpwilson Corresponding PRs to update the SBR in each microservice are here: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two recent changes to the Service Binding Operator mean that the current
ServiceBindingRequests no longer function, and two corresponding updates are required:applicationSelectornow that Support creation of managed secret without associating it to a workload redhat-developer/service-binding-operator#350 is implemented. In fact, you must not do so if using with Appsody/OpenLiberty operators, otherwise both are trying to manage the same resource, and get into an endless loop of updating the deployment. (I wasn't able to identify exactly which SBO change has triggered this)backingServiceSelector(singular) is being deprecated in favour ofbackingServiceSelectors. This was discussed in Support multiple backing services in customEnvVar / dataMapping redhat-developer/service-binding-operator#396 and implemented in Introduce id field in service selector to be used as shortcut in custom environment variables redhat-developer/service-binding-operator#468. In order to distinguish between backing services, you now need to give them anidand reference that in the Go template expression.This PR addresses both issues.