Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ServiceBindingRequests to work with latest Operator #2

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Update ServiceBindingRequests to work with latest Operator #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0548a
Remove applicationSelector as it is no longer required
djones6 Sep 9, 2020
005b7c4
Replace backingServiceSelector with backingServiceSelectors
djones6 Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 4 additions & 9 deletions environments/coffeeshop-dev/services/barista-kafka/base/config/service-binding-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,18 @@ kind: ServiceBindingRequest
metadata:
name: barista-kafka
spec:
# applicationSelector isn't needed anymore once https://github.com/redhat-developer/service-binding-operator/issues/296 is implemented
applicationSelector:
group: apps
resource: deployments
resourceRef: barista-kafka
version: v1
# Service Binding Operator doesn't support binding across namespaces until https://github.com/redhat-developer/service-binding-operator/issues/314 is implemented.
# Assumption: Kafka and the application are deployed to the same namespace
backingServiceSelector:
group: kafka.strimzi.io
backingServiceSelectors:
- group: kafka.strimzi.io
kind: Kafka
resourceRef: my-cluster
version: v1beta1
id: mycluster
customEnvVar:
- name: KAFKA_BOOTSTRAP_SERVERS
value: |-
{{- range .status.listeners -}}
{{- range .mycluster.status.listeners -}}
{{- if eq .type "plain" -}}
{{ .bootstrapServers }}
{{- end -}}
Expand Down
13 changes: 4 additions & 9 deletions environments/coffeeshop-dev/services/coffeeshop-ui/base/config/service-binding-request.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,23 +3,18 @@ kind: ServiceBindingRequest
metadata:
name: coffeeshop-ui-kafka
spec:
# applicationSelector isn't needed anymore once https://github.com/redhat-developer/service-binding-operator/issues/296 is implemented
applicationSelector:
group: apps
resource: deployments
resourceRef: coffeeshop-ui
version: v1
# Service Binding Operator doesn't support binding across namespaces until https://github.com/redhat-developer/service-binding-operator/issues/314 is implemented.
# Assumption: Kafka and the application are deployed to the same namespace
backingServiceSelector:
group: kafka.strimzi.io
backingServiceSelectors:
- group: kafka.strimzi.io
kind: Kafka
resourceRef: my-cluster
version: v1beta1
id: mycluster
customEnvVar:
- name: MP_MESSAGING_CONNECTOR_LIBERTY_KAFKA_BOOTSTRAP_SERVERS
value: |-
{{- range .status.listeners -}}
{{- range .mycluster.status.listeners -}}
{{- if eq .type "plain" -}}
{{ .bootstrapServers }}
{{- end -}}
Expand Down