Revert fix for skipBytes and backport fix from jdk17 #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ee1497e. Signed-off-by: Rahil Shah <rahil@ca.ibm.com>
…ompressed file Reviewed-by: martin, alanb
|
@pshipton I have reverted the commit from #559 and backported the fix from JDK17. Can you please review the changes. Also similar to comment made in ibmruntimes/openj9-openjdk-jdk8#609 (comment), I have not changed copyright as change was ported from JDK17 repo. |
|
The test passed on rhel9s390xrt-1. lgtm |
pshipton
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit in this PR reverts the fix that was merged in #559 to fix the failures seen in test DeflateIn_InflateOut.skipBytes. The test was fixed in JDK17 and it is preferable to port fixes that were made in jdk17+ repository so second commit in this PR backports fix from JDK17 repository.
Issue eclipse-openj9/openj9#14948