JDK8: Backport 8240226 from JDK17 to fix DeflateIn_InflateOut.skipBytes #609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Porting the JDK test fix from ibmruntimes/openj9-openjdk-jdk11#559 |
|
I see the copyright check is failing. We need to add an IBM copyright statement after the Oracle copyright/license. I guess we missed that for jdk11 so it should be updated as well. |
|
Test passed in a grinder on rhel9s390xrt-1 |
|
As per ibmruntimes/openj9-openjdk-jdk11#559 (comment) I believe the plan is now to backport the test fix from jdk17. Setting this as draft until it's updated or closed. |
…ompressed file Reviewed-by: martin, alanb
r30shah
force-pushed
the
testRestSizeJDK8
branch
from
b25bfd5
to
143668c
Compare
r30shah
changed the title
|
@pshipton I have backported JDK17 fix to JDK8 and also changed the title of the PR. As this change was ported from JDK17, did not update the Copyright. Let me know if we need to change it. |
|
Still passing a grinder on rhel9s390xrt-1. lgtm |
pshipton
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java/util/zip/DeflateIn_InflateOut.skipBytes verifies functionality of DeflaterInputStream.skipBytes. While testing skipping of bytes, test uses different input data with same data length, and compares the compressed sizes of these data to verify skipping bytes. As per zlib specification which is what is used by Deflater in java, length of compressed data is highly dependable on input data contents, so it will be incorrect to assume that compression ratio would be constant for same length input data. For more details please see explaination in eclipse-openj9/openj9#14948 (comment).
Signed-off-by: Rahil Shah rahil@ca.ibm.com