[minor] Fix pixel ordering and selection of best-fit direction #75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort grid values and corresponding arrays in descending order after application of Gaussian smoothing and interpolation from the equatorial map.
Change min function to nanmin to handle NaN values.
azegarelli
approved these changes
Dec 4, 2025
Contributor
azegarelli
left a comment
azegarelli
left a comment
There was a problem hiding this comment.
I have checked these changes on a few events that were presenting the problem before, and now there aren't mistmaches anymore between the pixel with the highest probability value and the best-fit directions returned by skyreader and then saved in the file's header.
I approve these changes
G-Sommani
changed the title
tianluyuan
approved these changes
Dec 4, 2025
ric-evans
reviewed
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The switch to a probability map is applied (with an eventual Gaussian smoothing) to the
equatorial_map. This is subsequently applied togrid_value(the actual multiorder map) through an interpolation. Both the Gaussian smoothing and the interpolation can slightly change the position of the best-fit direction. Previously, the best-fit direction was taken fromgrid_valuebefore the Gaussian smoothing and the interpolation. This created mismatches between the best-fit direction in the header and the actual best-fit direction in the multiorder map. The pull request aims to fix this by taking the best-fit direction after the application of smoothing and interpolation.