Skip to content

[minor] Fix pixel ordering and selection of best-fit direction #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G-Sommani merged 3 commits into from
Dec 5, 2025
Merged

[minor] Fix pixel ordering and selection of best-fit direction #75

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
622efc6
Sort grid values and related arrays for second time
G-Sommani Dec 3, 2025
e7eedc1
Avoid repetitions in sorting of grid values and coordinates
G-Sommani Dec 3, 2025
4f6bb19
Use np.nanmin for minimum value calculation
G-Sommani Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 8 additions & 7 deletions skyreader/utils/handle_map_data.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,7 @@ def extract_map(
grid_value: np.ndarray = np.asarray(grid_value_list)
uniq_array: np.ndarray = np.asarray(uniq_list)

sorting_indices = np.argsort(grid_value)
grid_value = grid_value[sorting_indices]
grid_dec = grid_dec[sorting_indices]
grid_ra = grid_ra[sorting_indices]
uniq_array = uniq_array[sorting_indices]

min_value = grid_value[0]
min_value = np.nanmin(grid_value)

if remove_min_val or (not llh_map):
# renormalize
Expand All @@ -111,6 +105,7 @@ def extract_map(
# show 2 * delta_LLH
grid_value = grid_value * 2.
equatorial_map *= 2.
sorting_indices = np.argsort(grid_value)
else:
# Convert to probability
equatorial_map = np.exp(-1. * equatorial_map)
Expand All @@ -137,6 +132,12 @@ def extract_map(
equatorial_map, np.pi/2 - grid_dec, grid_ra
)
grid_value = grid_value.clip(min_map, None)
sorting_indices = np.argsort(-grid_value)

grid_value = grid_value[sorting_indices]
grid_dec = grid_dec[sorting_indices]
grid_ra = grid_ra[sorting_indices]
uniq_array = uniq_array[sorting_indices]

return grid_value, grid_ra, grid_dec, equatorial_map, uniq_array

Expand Down
Loading