-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CD via Github Actions #351
Conversation
Cool, thanks! This looks great, I guess it replaces the Azure Pipeline I added in #346, but it is better since it adds publishing binary releases. I see it also uses a static CRT for Windows, implementing #318. I'll merge this as-is but we should see about combining the functionality of azure-pipelines.yml into .github/workflows/build.yaml, haven't looked at it in depth but a few preliminary notes:
|
Should probably open a tracking issue for this, lest i forget.
It helps a lot with final executable size. How about also uploading a debug build - as far as i'm aware we have to build in debug anyways for clippy to work.
Agreed, the big question is should it be part of the same job, or run separately?
The executable flags are a problem (actions/upload-artifact#38 among others) - unless one archives their executables before uploading, executable bits will be reset. For linux, i don't see it as much of a problem; linux users are savvy enough to chmod. MacOS should be done by just packing an app, that has to be archived anyways.
Github actions always zips by default(actions/upload-artifact#39), there's no way around that. The releases page is unaffected, see https://github.com/MCOfficer/stevenarella/releases/tag/test4 As for the version, one can put it in the window title. PS: Thanks for the invitation, but i rejected - i don't see much to gain since i would be pushing PRs anyways, and the risk of me pushing to the wrong remote is too high in my book. Let's just say it happened before. |
Filed #352 for future enhancements (can be fixed separately)
No worries, thank you regardless for your contributions! |
Closes #93
This PR adds a Github Actions workflow that builds binaries and publishes them on the workflow page. If the workflow runs on a tag, it will also publish to the releases page.
The workflow runs on every new push, tag or release.