-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI/CD consolidation/enhancements: macOS .app bundling #352
Labels
enhancement
New feature or request
Comments
Notes:
PS: Jesus, that's a lot of CIs :D |
iceiix
added a commit
that referenced
this issue
Jul 5, 2020
Consolidates the multitude of CI systems, replacing Azure, SourceHut, and AppVeyor with GitHub Actions, which now also runs clippy and fmt. See #352 * Add task to run clippy * Add task to check formatting * Test on 1.44.1 toolchain * Update readme: status badge and downloads on GitHub Actions * Remove strip binary task, leave it unstripped to allow debugging for now * Rename task to install dependencies * Remove Azure Pipelines * Remove sr.ht SourceHut CI * Remove AppVeyor
iceiix
added a commit
that referenced
this issue
Jul 5, 2020
Consolidates the multitude of CI systems, replacing Azure, SourceHut, and AppVeyor with GitHub Actions, which now also runs clippy and fmt. See #352 * Add task to run clippy * Add task to check formatting * Test on 1.44.1 toolchain * Update readme: status badge and downloads on GitHub Actions * Remove strip binary task, leave it unstripped to allow debugging for now * Rename task to install dependencies * Remove Azure Pipelines * Remove sr.ht SourceHut CI * Remove AppVeyor
iceiix
changed the title
CI/CD consolidation/enhancements
CI/CD consolidation/enhancements: macOS .app bundling
Jul 25, 2020
iceiix
added a commit
that referenced
this issue
Jan 19, 2021
Updates to enhance GitHub Actions continuous integration: * ci: add macOS app bundle packaging using cargo-bundle, closes #352 based on https://github.com/EndlessSkyCommunity/ESLauncher2/blob/master/Cargo.toml * ci: add web target, building using wasm-pack (for #446) * ci: refactor and cleanup targets, split out instead of using matrix * main: save config in consistent OS-specific dirs::config_dir() Instead of storing and loading in the current working directory, change to a consistent dedicated configuration directory. This is necessary for .app launching since cwd is set to /. To preserve compatibility with existing installations, if conf.cfg exists in cwd then it will be used instead, but otherwise we will use the operating system specific config dirs: // Lin: Some(/home/alice/.config) // Win: Some(C:\Users\Alice\AppData\Roaming) // Mac: Some(/Users/Alice/Library/Application Support) * macos: add icons based on screenshotted logo * macos: add Cmd-Q to quit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow-on to #351, which adds GitHub Actions, to complement the existing Azure Pipelines (#346), SourceHut (#176), and AppVeyor (#9) (also considered: CircleCI #174, Travis-CI #173). Consolidate all the CI systems into one, probably GitHub Actions, with a superset of the functionality:
cargo clippy
, for reference this is executed in Azure Pipelines (move to GitHub Actions, probably fine as the same job as the build)see notes in #351 (comment)
The text was updated successfully, but these errors were encountered: